Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Restore PR-5392 to develop #5586

Merged
merged 3 commits into from
Oct 7, 2019
Merged

Restore PR-5392 to develop #5586

merged 3 commits into from
Oct 7, 2019

Conversation

keharper
Copy link
Contributor

@keharper keharper commented Oct 5, 2019

Purpose of this pull request

#4726 added the "CSS Critical Path" topic for 2.2 and 2.3, but it was incorrectly merged into master instead of develop.

#5392 removed this information from master.

This pull request (PR) restores the information originally added in #4726, but into develop.

This PR also adds navigation and gives a light edit for grammar and future linting requirements. The new topic could use additional editing, but that's beyond the scope of this PR.

whatsnew
Added the new topic CSS Critical Path to the Frontend Developer Guide.

@keharper keharper self-assigned this Oct 5, 2019
@keharper keharper added 2.2.10 xx2.3.3 Magento 2.3.3 changes Internal Dev Differentiates work between community and Magento staff New Topic A major update published as an entirely new document labels Oct 5, 2019
@keharper keharper requested a review from dobooth October 5, 2019 04:54
@dobooth
Copy link
Contributor

dobooth commented Oct 7, 2019

running tests

@dobooth dobooth merged commit 7dd339a into develop Oct 7, 2019
@ghost
Copy link

ghost commented Oct 7, 2019

Hi @keharper, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dobooth dobooth deleted the kh_restore-5392 branch October 7, 2019 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Internal Dev Differentiates work between community and Magento staff New Topic A major update published as an entirely new document xx2.3.3 Magento 2.3.3 changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants