Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Add command to configure varnish section so that Varnish is purged wh… #5721

Merged
merged 4 commits into from
Oct 22, 2019

Conversation

mattskr
Copy link

@mattskr mattskr commented Oct 16, 2019

Purpose of this pull request

Updates cloud docker documentation with the extra command to configure Varnish as a http-cache-host so that Varnish will purge when you do a Magento cache clean

Affected DevDocs pages

https://devdocs.magento.com/guides/v2.3/cloud/docker/docker-config.html
https://devdocs.magento.com/guides/v2.2/cloud/docker/docker-config.html

Links to documentation on how to configure Varnish

https://devdocs.magento.com/guides/v2.3/config-guide/varnish/use-varnish-cache.html

whatsnew
Updated the Cloud launch modes documentation to configure Varnish as a http-cache-host so that Varnish purges with a Magento cache clean.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@hguthrie hguthrie self-assigned this Oct 17, 2019
@hguthrie hguthrie added Technical Updates to the code or processes that alter the technical content of the doc Waiting for Response Waiting for response from internal/external parties labels Oct 22, 2019
@hguthrie
Copy link
Contributor

I marked waiting for response because I am waiting for an internal dev to get back to me. I'm in the process of updating the Varnish section. I want to make sure this is placed properly. Thanks for your patience!

@mveeramneni
Copy link

Hi @hguthrie, I QA'ed the changes and everything is working good. I have one suggestion for @mattskr, can you please make the same change for production mode too?
Thank you.

@mattskr
Copy link
Author

mattskr commented Oct 22, 2019

yes, I will do that now.

@hguthrie
Copy link
Contributor

running tests

@hguthrie
Copy link
Contributor

Thanks @mattskr 👍

@hguthrie hguthrie merged commit 31e87b9 into magento:master Oct 22, 2019
@ghost
Copy link

ghost commented Oct 22, 2019

Hi @mattskr, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@hguthrie hguthrie added 2.x and removed Waiting for Response Waiting for response from internal/external parties labels Oct 22, 2019
@mattskr mattskr deleted the update-launch-docker-varnish-command branch October 22, 2019 19:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.x Partner: Zilker Technology partners-contribution PR created by Magento partner Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants