Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

meker12
Copy link
Contributor

@meker12 meker12 commented Oct 22, 2019

Purpose of this pull request

  • Clarified that smart wizard checks to ensure Cloud configuration follows best practices for SCD strategy
  • Added step to validate Elasticsearch service version compatibility with Elasticsearch PHP client
  • Updated Elasticsearch set up topic with info about compatibility checks

Summary of changes

Updates to best practices for deployment

  • Clarified that smart wizard checks to ensure Cloud configuration follows best practices for SCD strategy
  • Added step to validate Elasticsearch service version compatibility with Elasticsearch PHP client

Updates to Elasticsearch set up

  • Added Support recommendation to always set up Elasticsearch even if using a third-party search tool
  • Added procedure to check Elasticsearch software compatibility
  • Added an "Additional Search Configuration" section to provide details about completing additional search configuration through Cloud deploy variable and Magento Admin UI.

Affected DevDocs pages

whatsnew
Added the following information to the Set up Elasticsearch
topic in the Cloud Guide
- Recommendation to always set up
Elasticsearch as a fallback option if using a third-party search tool.
- Instructions for checking Elasticsearch software compatibility.
- "Additional Search Configuration"
section with details about customizing search options and testing Elasticsearch.

meker12 and others added 5 commits October 22, 2019 10:56
- Clarified that smart wizard checks to ensure  Cloud configuration follows best practices for SCD strategy
- Added step to validate Elasticsearch service version compatibility with Elasticsearch PHP client
@meker12 meker12 added the Major Update Significant original updates to existing content label Oct 24, 2019
@meker12 meker12 self-assigned this Oct 24, 2019
Copy link
Contributor

@hguthrie hguthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, some small things to fix. So far it looks good.


## Elasticsearch software compatibility

When you install or upgrade your {{ site.data.var.ece }} project, always check for compatibility between the Elasticsearch service version and the [Elasticsearch PHP](https://github.com/elastic/elasticsearch-php) client for {{ site.data.var.ee }}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY!

In the response, find the IP address for the Elasticsearch service endpoint:

```terminal
"elasticsearch" : [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to change this to show the results from the CLI.

@meker12 meker12 marked this pull request as ready for review October 24, 2019 16:04
```terminal
| elasticsearch: |
+------------------------------------------+----------------------------------------------------------------------+
| username | null |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would manually remove some of the white space from the first column. It really takes up a lot of screen space and might be annoying for someone on a mobile device.

@meker12
Copy link
Contributor Author

meker12 commented Oct 25, 2019

running tests

@ghost
Copy link

ghost commented Oct 26, 2019

Hi @meker12, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@meker12 meker12 added 2.x Internal Dev Differentiates work between community and Magento staff labels Oct 26, 2019
@meker12 meker12 deleted the mae-MAGECLOUD-4326-updates branch October 29, 2019 02:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.x Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants