Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Add hashing topic to Security guide #5874

Merged
merged 7 commits into from
Oct 29, 2019
Merged

Add hashing topic to Security guide #5874

merged 7 commits into from
Oct 29, 2019

Conversation

dobooth
Copy link
Contributor

@dobooth dobooth commented Oct 29, 2019

Purpose of this pull request

This pull request (PR) adds a new topic to the Config Guide, Security section, about hashing passwords.

Affected DevDocs pages

whatsnew
Added the Password Hashing topic to the Configuration Guide.

@dobooth dobooth added 2.2.x 2.3.x Magento 2.3 related changes New Topic A major update published as an entirely new document labels Oct 29, 2019
@dobooth dobooth self-assigned this Oct 29, 2019
Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing the graphics to SVG so that they can be searched.

To avoid compromising passwords which have been hashed with outdated algorithms like `MD5` and have not been updated in a while, the current implementation provides a method to upgrade the hash without changing the original password. In general, the password hash has the following format:

```text
password_hash:salt:version0:versionn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the second n in versionn a variable? If yes, change it to version<n>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

title: Password hashing
---

## Overview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary heading

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gone.


## Implementation

The `\Magento\Framework\Encryption\Encryptor` is responsible for password hash generation and verification. The `bin/magento customer:hash:upgrade` command upgrades a customer password hash to the latest hash algorithm.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "class" after Encryptor?

Add a link to the command.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

dobooth and others added 5 commits October 29, 2019 13:32
Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>
Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>
Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>
Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>
@dobooth
Copy link
Contributor Author

dobooth commented Oct 29, 2019

running tests

@dobooth dobooth merged commit 727ce5f into master Oct 29, 2019
@ghost
Copy link

ghost commented Oct 29, 2019

Hi @dobooth, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dobooth dobooth deleted the db_arch_hashing branch October 29, 2019 19:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.2.x 2.3.x Magento 2.3 related changes New Topic A major update published as an entirely new document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants