-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add hashing topic to Security guide #5874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider changing the graphics to SVG so that they can be searched.
To avoid compromising passwords which have been hashed with outdated algorithms like `MD5` and have not been updated in a while, the current implementation provides a method to upgrade the hash without changing the original password. In general, the password hash has the following format: | ||
|
||
```text | ||
password_hash:salt:version0:versionn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the second n
in versionn
a variable? If yes, change it to version<n>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
title: Password hashing | ||
--- | ||
|
||
## Overview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary heading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gone.
|
||
## Implementation | ||
|
||
The `\Magento\Framework\Encryption\Encryptor` is responsible for password hash generation and verification. The `bin/magento customer:hash:upgrade` command upgrades a customer password hash to the latest hash algorithm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add "class" after Encryptor
?
Add a link to the command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>
Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>
Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>
Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>
running tests |
Hi @dobooth, thank you for your contribution! |
Purpose of this pull request
This pull request (PR) adds a new topic to the Config Guide, Security section, about hashing passwords.
Affected DevDocs pages
whatsnew
Added the Password Hashing topic to the Configuration Guide.