Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

magento/devdocs#: Get IP of Cloud instance #5883

Merged
merged 2 commits into from
Oct 31, 2019
Merged

magento/devdocs#: Get IP of Cloud instance #5883

merged 2 commits into from
Oct 31, 2019

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Oct 30, 2019 •
edited by meker12
Loading

Purpose of this pull request

This pull request (PR) adds information how to get IP address of Cloud instance.

Affected DevDocs pages

Links to Magento source code

5883

Thank you!

whatsnew
Added an example for retrieving the IP address of a particular Cloud instance to the Integration environment IP address section in the Cloud Guide.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@atwixfirster atwixfirster force-pushed the cloud-get-ip-of-cloud-instance branch 2 times, most recently from 5dac06e to e599d49 Compare October 30, 2019 14:48
@rogyar rogyar self-assigned this Oct 30, 2019
@rogyar
Copy link
Contributor

rogyar commented Oct 30, 2019

I still wonder why don't people use ping for this purpose. Basically, there is a variety of options how to achieve that. But from my perspective, the ping operation is most basic since it's present on most desktop systems (even Windows) out of the box.

@atwixfirster atwixfirster force-pushed the cloud-get-ip-of-cloud-instance branch from e599d49 to 6233a94 Compare October 30, 2019 20:57
@atwixfirster
Copy link
Contributor Author

I still wonder why don't people use ping for this purpose. Basically, there is a variety of options how to achieve that. But from my perspective, the ping operation is most basic since it's present on most desktop systems (even Windows) out of the box.

The existing Cloud documentation refers to dig command-line tool so I decided to keep this style :)

Added an example with ping.

Could you please review?

Thank you!

@rogyar rogyar added Technical Updates to the code or processes that alter the technical content of the doc 2.2.x 2.3.x Magento 2.3 related changes labels Oct 31, 2019
@hguthrie hguthrie self-assigned this Oct 31, 2019
hguthrie
hguthrie suggested changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@hguthrie hguthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be very helpful. I made a few suggestions to maintain consistency and to use terms found in the Magento Cloud CLI. Thanks!

guides/v2.2/cloud/env/environments-start.md
@@ -226,6 +226,25 @@ If you have a corporate firewall that blocks outgoing SSH connections, you can a
</tr>
</table>

## Get IP address of Cloud instance

Use `ping` command for retrieving IP address for particular Cloud instance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use `ping` command for retrieving IP address for particular Cloud instance.
You can retrieve the IP address for a particular Cloud instance using a `ping` command and the environment URL or hostname:

guides/v2.2/cloud/env/environments-start.md

Use `ping` command for retrieving IP address for particular Cloud instance.

Example of usage:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is not necessary.

@hguthrie
Copy link
Contributor

hguthrie commented Oct 31, 2019 •
edited
Loading

Yes, the dig command has been noted in an older topic of the Cloud guide regarding a verification for Fastly caching. It is best to remain as generic as possible when suggesting methods for verification and using only official references when linking to external sites for further information.

Thanks for the contribution!

@atwixfirster atwixfirster force-pushed the cloud-get-ip-of-cloud-instance branch from 6233a94 to 271080d Compare October 31, 2019 16:24
@atwixfirster
Copy link
Contributor Author

Thanks for the contribution!

With my pleasure!

@hguthrie
Copy link
Contributor

running tests

@hguthrie hguthrie merged commit 013dc33 into magento:master Oct 31, 2019
@ghost
Copy link

ghost commented Oct 31, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rogyar rogyar rogyar approved these changes

@hguthrie hguthrie hguthrie approved these changes

Assignees

@rogyar rogyar

@hguthrie hguthrie

Labels
2.2.x 2.3.x Magento 2.3 related changes Partner: Atwix partners-contribution PR created by Magento partner Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atwixfirster @devops-devdocs @rogyar @hguthrie @magento-engcom-team