Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

konarshankar07
Copy link
Contributor

Purpose of this pull request

This pull request (PR) will add the option for secure DB connection whilst installation done via cli

Affected DevDocs pages

Links to Magento source code

Fixes #5951

drpayyne and others added 30 commits November 12, 2019 19:24
  - Missing article
MAGECLOUD-4655 Update config file extension for Blackfire
Use double quotes for Build number variable in rake build:stage
Fixed incorrect module dependency examples
Replace a bash variable with ENV syntax in rake build:stage
* Added product recs

* Added qualification for Google extension
Adding the widget available options
…stomerAddress

magento/devdocs#: Add updateCustomerAddress mutation API errors
@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@konarshankar07
Copy link
Contributor Author

I've deleted the symlink to the Magento 2.3 version doc but in order to do that somehow Magento 2.2 version doc link is broken. Any would be appreciated!
Thanks

@rogyar rogyar self-assigned this Nov 18, 2019
@jeff-matthews jeff-matthews added the 2.3.4 Magento 2.3.4 changes label Nov 18, 2019
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @konarshankar07. Since the described change has not been released yet, we need to use the develop branch as a base for such PRs. Please, change the base of your PR. Thank you!

@konarshankar07 konarshankar07 changed the base branch from master to develop November 18, 2019 15:37
@rogyar
Copy link
Contributor

rogyar commented Nov 18, 2019

Hi @konarshankar07. It looks like the direct base change will not work since the branch needs to be created from the develop mainline, not from master.

@keharper
Copy link
Contributor

@konarshankar07 There's now merge conflicts, and so I'd recommend starting over with a new PR off the develop branch.

To break a symlink

  1. From the devdocs directory, run the following command:

git rm guides/v2.3/path/to/file.md

  1. Copy the file from the 2.2 directory to the 2.3 directory:
    cp guides/v2.2/path/to/file.md guides/v2.3/path/to/file.md

  2. Make all edits in the 2.3 file.

@konarshankar07
Copy link
Contributor Author

Hello @rogyar and @keharper ,
I have created a new PR #6021 and closing this one.
Thanks

@ghost
Copy link

ghost commented Nov 18, 2019

Hi @konarshankar07, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.