Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

meker12
Copy link
Contributor

@meker12 meker12 commented Nov 27, 2019

Purpose of this pull request

  • Updated prelaunch-checklist attachment with latest version in PDF format
  • Updated checklist link to point to PDF version
  • Changed filename to general name for easy update via PDF upload
  • Added security configuration section to Go Live Checklist topic
  • Updated links in the Product configuration section

Affected DevDocs pages

whatsnew
Added the Security configuration section to the "Go live checklist" topic in the Cloud Guide and replaced the current Go live checklist document attachment with the most recent version, which is more comprehensive and up-to-date.

- Added security configuration section to Go Live Checklist topic
- Updated links in the Product configuration section
@meker12 meker12 self-assigned this Nov 27, 2019
@meker12 meker12 requested a review from keharper November 27, 2019 19:05
@meker12 meker12 added 2.x Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content labels Nov 27, 2019
Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check that the link text is appropriate. I'm not insisting that they be changed.

- [WebPageTest](https://www.webpagetest.org/) and [Pingdom](https://www.pingdom.com/): Real-time analysis of your site pages load time with different origin locations. Pingdom may cost a fee. WebPageTest is a free tool.

## Security configuration

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change hardcoded links to devdocs topics so that they use the page.baseurl variable


## Security configuration

- [Setup your Magento Security Scan](https://devdocs.magento.com/guides/v2.3/cloud/live/live.html#security-scan)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text in the topic target says "Set up your..."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text in the link to the two merchdoc topics below don't agree with the actual title. Verify that this is intended.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intended to have contextual text in the link instead of exact topic title.

Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>
@meker12 meker12 requested a review from keharper November 27, 2019 20:03
Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I did not review the contents of the PDF file because that file comes from a source outside of devdocs.

@meker12
Copy link
Contributor Author

meker12 commented Nov 27, 2019

running tests

@meker12
Copy link
Contributor Author

meker12 commented Nov 27, 2019

running tests

@meker12 meker12 merged commit 7a1799b into master Nov 27, 2019
@ghost
Copy link

ghost commented Nov 27, 2019

Hi @meker12, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper keharper deleted the mae-magecloud-4312-go-live-checklist-updates branch December 2, 2019 18:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.x Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants