Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

MAGECLOUD-3378 scaled architecture #6119

Merged
merged 31 commits into from
Jan 7, 2020
Merged

MAGECLOUD-3378 scaled architecture #6119

merged 31 commits into from
Jan 7, 2020

Conversation

hguthrie
Copy link
Contributor

@hguthrie hguthrie commented Dec 4, 2019 •
edited by meker12
Loading

The purpose of this PR is to present the current scaled architecture topic for technical review. There are many points that are not complete.

  • Complete topic, or add further topics and updates
  • Technical review
  • Link/lint/image checks
  • Add whatsnew, labels

whatsnew
Added a topic to the Cloud Guide describing the new Scaled architecture.

@hguthrie hguthrie requested a review from BaDos December 4, 2019 17:14
@hguthrie hguthrie self-assigned this Dec 4, 2019
BaDos
BaDos reviewed Dec 4, 2019
View reviewed changes
BaDos
BaDos reviewed Dec 4, 2019
View reviewed changes
BaDos
BaDos reviewed Dec 4, 2019
View reviewed changes
BaDos
BaDos reviewed Dec 4, 2019
View reviewed changes
BaDos
BaDos reviewed Dec 4, 2019
View reviewed changes
@hguthrie hguthrie added the Internal Dev Differentiates work between community and Magento staff label Dec 9, 2019
@hguthrie hguthrie requested a review from YPyltiai December 13, 2019 21:37
YPyltiai
YPyltiai suggested changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@YPyltiai YPyltiai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good overall but need few minor changes, please.

@hguthrie hguthrie added the 2.x label Dec 16, 2019
meker12
meker12 suggested changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@meker12 meker12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few suggestions for clarity. Could use some work on transitions between sections and clarification of split architecture, scaled architecture terminology. In some cases, conciseness makes it difficult to understand the concepts and examples.

meker12
meker12 reviewed Dec 20, 2019
View reviewed changes
@meker12 meker12 self-requested a review January 6, 2020 16:25
@hguthrie
Copy link
Contributor Author

hguthrie commented Jan 7, 2020

running tests

@hguthrie hguthrie merged commit c5d9218 into master Jan 7, 2020
@ghost
Copy link

ghost commented Jan 7, 2020

Hi @hguthrie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dobooth dobooth deleted the hg-horizontalscaling branch January 16, 2020 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BaDos BaDos BaDos left review comments

@meker12 meker12 meker12 approved these changes

@YPyltiai YPyltiai YPyltiai approved these changes

Assignees

@hguthrie hguthrie

@meker12 meker12

Labels
2.x Internal Dev Differentiates work between community and Magento staff New Topic A major update published as an entirely new document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hguthrie @BaDos @meker12 @YPyltiai