Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Information added for all the nodes in env.php #6167

Merged
merged 4 commits into from
Dec 12, 2019

Conversation

ajithkumar-maragathavel
Copy link
Contributor

@ajithkumar-maragathavel ajithkumar-maragathavel commented Dec 10, 2019

Purpose of this pull request

Additional information added for all the nodes in app/etc/env.php

Affected DevDocs pages

Fixes #5927

whatsnew
Added reference information to the env.php reference topic in the Configuration Guide.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@dobooth
Copy link
Contributor

dobooth commented Dec 10, 2019

Hi @ajithkumar-maragathavel Thanks for the contribution. Here is the dilemma: It would be better to either document all the attributes or none of them, rather than just one. Any interest in fleshing out the rest of the attributes?

@dobooth dobooth self-assigned this Dec 10, 2019
@dobooth dobooth added 2.3.x Magento 2.3 related changes and removed Progress: review labels Dec 10, 2019
@ajithkumar-maragathavel
Copy link
Contributor Author

@dobooth I will document all the attributes and it's purpose and commit the changes.

@ajithkumar-maragathavel ajithkumar-maragathavel changed the title Information added for backend node in env.php Information added for all the node in env.php Dec 11, 2019
@ajithkumar-maragathavel ajithkumar-maragathavel changed the title Information added for all the node in env.php Information added for all the nodes in env.php Dec 11, 2019
@ajithkumar-maragathavel
Copy link
Contributor Author

@dobooth I have added information for the all the attributes in env.php as you suggested. Please review it. Thanks for your suggestion.

@dobooth dobooth added the Major Update Significant original updates to existing content label Dec 12, 2019
@dobooth
Copy link
Contributor

dobooth commented Dec 12, 2019

Ah good man! Thanks for the effort, @ajithkumar-maragathavel!

@dobooth
Copy link
Contributor

dobooth commented Dec 12, 2019

running tests

@dobooth dobooth merged commit a74b190 into magento:master Dec 12, 2019
@ghost
Copy link

ghost commented Dec 12, 2019

Hi @ajithkumar-maragathavel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content Partner: Ziffity partners-contribution PR created by Magento partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants