Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Added additional php doc blocks with examples #6223

Merged
merged 8 commits into from
Jan 17, 2020
Merged

Added additional php doc blocks with examples #6223

merged 8 commits into from
Jan 17, 2020

Conversation

srsathish92
Copy link
Contributor

@srsathish92 srsathish92 commented Dec 17, 2019 •
edited by dobooth
Loading

Purpose of this pull request

This pull request (PR) helps to add additional DocBlock tags with examples in DocBlock standard page

Affected DevDocs pages

https://devdocs.magento.com/guides/v2.3/coding-standards/docblock-standard-general.html

whatsnew
Added @method and @link information to Coding Standards.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@osrecio osrecio self-assigned this Dec 18, 2019
@keharper keharper added 2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content labels Dec 18, 2019
@dobooth dobooth self-assigned this Jan 2, 2020
@dobooth
Copy link
Contributor

dobooth commented Jan 2, 2020

Hi @srsathish92 Thanks for the PR. Since this is a change to coding standards, we are asking for architects review. Also, we just recently stopped taking contributions for v2.2. Can you please port this change to update only the v2.3 file? Thanks!

@dobooth dobooth added the Waiting for Response Waiting for response from internal/external parties label Jan 2, 2020
@srsathish92
Copy link
Contributor Author

@dobooth sure, As requested I will update the same in separate file.

@srsathish92
Copy link
Contributor Author

@dobooth Updated the changes only in v2.3 file, can you please check now

buskamuza
buskamuza previously requested changes Jan 2, 2020
View reviewed changes
@srsathish92 srsathish92 requested a review from buskamuza January 3, 2020 05:05
lenaorobei
lenaorobei reviewed Jan 3, 2020
View reviewed changes
lenaorobei
lenaorobei reviewed Jan 3, 2020
View reviewed changes
@srsathish92 srsathish92 requested a review from lenaorobei January 3, 2020 19:04
@dobooth
Copy link
Contributor

dobooth commented Jan 8, 2020

Good to go, @lenaorobei @buskamuza ?

lenaorobei
lenaorobei reviewed Jan 8, 2020
View reviewed changes
@srsathish92 srsathish92 requested a review from lenaorobei January 9, 2020 11:26
@srsathish92
Copy link
Contributor Author

@dobooth @lenaorobei @buskamuza Thanks for the feedback, did you have any chance to review updated changes? please let me know if need changes.

@dobooth
Copy link
Contributor

dobooth commented Jan 16, 2020

Good to go, @lenaorobei ?

@dobooth dobooth dismissed buskamuza’s stale review January 17, 2020 15:54

Change was implemented as requested.

@dobooth dobooth removed the Waiting for Response Waiting for response from internal/external parties label Jan 17, 2020
@dobooth
Copy link
Contributor

dobooth commented Jan 17, 2020

running tests

@dobooth dobooth merged commit db192bd into magento:master Jan 17, 2020
@ghost
Copy link

ghost commented Jan 17, 2020

Hi @srsathish92, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lenaorobei lenaorobei lenaorobei approved these changes

@buskamuza buskamuza Awaiting requested review from buskamuza

Assignees

@osrecio osrecio

@lenaorobei lenaorobei

@dobooth dobooth

Labels
2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content Partner: Ziffity partners-contribution PR created by Magento partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@srsathish92 @devops-devdocs @dobooth @buskamuza @lenaorobei @osrecio @keharper @magento-engcom-team