Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Add the documentation for the CheckboxToggleNotice UI component #6233

Conversation

serhiyzhovnir
Copy link
Contributor

@serhiyzhovnir serhiyzhovnir commented Dec 18, 2019

Purpose of this pull request

This pull request (PR) adds the documentation for the CheckboxToggleNotice UI component.

Affected DevDocs pages

It is a new page.

Links to Magento source code

Example of usage:
I did not find a direct using of the CheckboxToggleNotice component in the Magento, but this component marked as @api.
Also, we noticed that the https://github.com/magento/magento2/blob/2.3/app/code/Magento/SalesRule/view/adminhtml/web/js/form/element/apply_to_shipping.js component inherits the CheckboxToggleNotice and the example of using the applyToShip component is here: https://github.com/magento/magento2/blob/2.3/app/code/Magento/SalesRule/view/adminhtml/ui_component/sales_rule_form.xml#L455-L481

whatsnew
Added a new topic about using the CheckboxToggleNotice UI component.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@rogyar rogyar added 2.2.x 2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc New Topic A major update published as an entirely new document and removed Technical Updates to the code or processes that alter the technical content of the doc labels Dec 18, 2019
@serhiyzhovnir
Copy link
Contributor Author

Hi @rogyar
I've added the detailed explanation for the tracks.notice option.
Please, check it again.
Thank you!

@serhiyzhovnir serhiyzhovnir requested a review from rogyar December 18, 2019 11:28
@jeff-matthews
Copy link
Contributor

running tests

@jeff-matthews jeff-matthews merged commit 1421470 into magento:master Dec 19, 2019
@ghost
Copy link

ghost commented Dec 19, 2019

Hi @serhiyzhovnir, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.2.x 2.3.x Magento 2.3 related changes New Topic A major update published as an entirely new document Partner: Atwix partners-contribution PR created by Magento partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants