-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Update css quick guide approach #6291
Conversation
An admin must run tests on this PR before it can be merged. |
1 similar comment
An admin must run tests on this PR before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@david-ziffity, is this really that different from the preceding sections about extending and overriding component styles? They look almost identical.
@jeff-matthews Yes it is different. The preceding sections are explaining about overriding or extending the Magneto's default ui component's style. The new one is explaining about overriding a module's styles, Since the module.less file is specific to modules and the file structure is different. But the overriding and extending concepts are same. |
Thanks for clarifying. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see editorial suggestions.
src/guides/v2.3/frontend-dev-guide/css-guide/css_quick_guide_approach.md
Outdated
Show resolved
Hide resolved
src/guides/v2.3/frontend-dev-guide/css-guide/css_quick_guide_approach.md
Outdated
Show resolved
Hide resolved
src/guides/v2.3/frontend-dev-guide/css-guide/css_quick_guide_approach.md
Outdated
Show resolved
Hide resolved
src/guides/v2.3/frontend-dev-guide/css-guide/css_quick_guide_approach.md
Outdated
Show resolved
Hide resolved
src/guides/v2.3/frontend-dev-guide/css-guide/css_quick_guide_approach.md
Outdated
Show resolved
Hide resolved
src/guides/v2.3/frontend-dev-guide/css-guide/css_quick_guide_approach.md
Outdated
Show resolved
Hide resolved
src/guides/v2.3/frontend-dev-guide/css-guide/css_quick_guide_approach.md
Outdated
Show resolved
Hide resolved
src/guides/v2.3/frontend-dev-guide/css-guide/css_quick_guide_approach.md
Outdated
Show resolved
Hide resolved
src/guides/v2.3/frontend-dev-guide/css-guide/css_quick_guide_approach.md
Outdated
Show resolved
Hide resolved
src/guides/v2.3/frontend-dev-guide/css-guide/css_quick_guide_approach.md
Outdated
Show resolved
Hide resolved
…pproach.md Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @david-ziffity
running tests |
@david-ziffity, tests failed due to markdown linting errors:
Please fix the errors. |
@jeff-matthews Fixed the errors. Please review it. Thanks for your support. |
running tests |
Hi @david-ziffity, thank you for your contribution! |
Purpose of this pull request
This pull request (PR) adds a new section to the css quick guide approach about extending module styles.
Affected DevDocs pages
whatsnew
Added a new section about extending module styles to the Frontend Developer Guide.