Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Update css quick guide approach #6291

Merged
merged 19 commits into from
Jan 3, 2020
Merged

Conversation

david-ziffity
Copy link
Contributor

@david-ziffity david-ziffity commented Dec 20, 2019

Purpose of this pull request

This pull request (PR) adds a new section to the css quick guide approach about extending module styles.

Affected DevDocs pages

whatsnew
Added a new section about extending module styles to the Frontend Developer Guide.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

1 similar comment
@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@jeff-matthews jeff-matthews added 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content labels Dec 20, 2019
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-ziffity, is this really that different from the preceding sections about extending and overriding component styles? They look almost identical.

@david-ziffity
Copy link
Contributor Author

@jeff-matthews Yes it is different. The preceding sections are explaining about overriding or extending the Magneto's default ui component's style. The new one is explaining about overriding a module's styles, Since the module.less file is specific to modules and the file structure is different. But the overriding and extending concepts are same.

@jeff-matthews
Copy link
Contributor

Thanks for clarifying.

Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see editorial suggestions.

david-ziffity and others added 13 commits January 2, 2020 20:02
…pproach.md

Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md

Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md

Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md

Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md

Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md

Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md

Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md

Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md

Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md

Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md

Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md

Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
david-ziffity and others added 2 commits January 2, 2020 20:08
…pproach.md

Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
…pproach.md

Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeff-matthews
Copy link
Contributor

running tests

@jeff-matthews
Copy link
Contributor

jeff-matthews commented Jan 2, 2020

@david-ziffity, tests failed due to markdown linting errors:

+ rake test:md
�[35mTesting Markdown style with mdl ...�[0m
�[31mThe Markdown linter detected 3 issue(s)�[0m
�[33msrc/guides/v2.3/frontend-dev-guide/css-guide/css_quick_guide_approach.md:99: MD012 Multiple consecutive blank lines
src/guides/v2.3/frontend-dev-guide/css-guide/css_quick_guide_approach.md:118: MD012 Multiple consecutive blank lines
src/guides/v2.3/frontend-dev-guide/css-guide/css_quick_guide_approach.md:141: MD012 Multiple consecutive blank lines

A detailed description of the rules is available at https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md

Please fix the errors.

@david-ziffity
Copy link
Contributor Author

@jeff-matthews Fixed the errors. Please review it. Thanks for your support.

@jeff-matthews
Copy link
Contributor

running tests

@jeff-matthews jeff-matthews merged commit a2bd7e9 into magento:master Jan 3, 2020
@ghost
Copy link

ghost commented Jan 3, 2020

Hi @david-ziffity, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content Partner: Ziffity partners-contribution PR created by Magento partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants