Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Added instruction to add new page layout #6532

Merged
merged 7 commits into from
Feb 18, 2020
Merged

Added instruction to add new page layout #6532

merged 7 commits into from
Feb 18, 2020

Conversation

ajithkumar-maragathavel
Copy link
Contributor

@ajithkumar-maragathavel ajithkumar-maragathavel commented Feb 2, 2020 •
edited by dobooth
Loading

Purpose of this pull request

This PR contains instructions for adding a new custom page layout in Magento.

Affected DevDocs pages

  • It's a new page.

whatsnew
Added the Create a new layout topic.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

1 similar comment
@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@aleron75
Copy link
Contributor

aleron75 commented Feb 3, 2020 •
edited
Loading

Hello @ajithkumar-maragathavel, thanks for your contribution!

Just a question: isn't this topic already covered here? https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/layouts/layout-types.html#layout-types-page

@ajithkumar-maragathavel
Copy link
Contributor Author

@aleron75 I just went through the link you provided. The page provides instructions about existing layouts and how it is implemented in Magento.
I am just trying to provide an example of creating a new layout and what files are required for it.
It can be useful for developers when they are trying to create a new page layout.

Please let me know your suggestions.
Thanks.

@rogyar rogyar self-assigned this Feb 3, 2020
rogyar
rogyar suggested changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ajithkumar-maragathavel. Thank you for your collaboration. Please, check my comments below

@rogyar rogyar added 2.3.x Magento 2.3 related changes New Topic A major update published as an entirely new document labels Feb 3, 2020
@rogyar
Copy link
Contributor

rogyar commented Feb 5, 2020

Much better now. Thank you!

rogyar
rogyar previously approved these changes Feb 5, 2020
View reviewed changes
dobooth
dobooth suggested changes Feb 12, 2020
View reviewed changes
dobooth
dobooth suggested changes Feb 13, 2020
View reviewed changes
@dobooth
Copy link
Contributor

dobooth commented Feb 18, 2020

running tests

@dobooth dobooth merged commit 319deea into magento:master Feb 18, 2020
@ghost
Copy link

ghost commented Feb 18, 2020

Hi @ajithkumar-maragathavel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@dobooth dobooth dobooth approved these changes

@rogyar rogyar rogyar left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@rogyar rogyar

@dobooth dobooth

Labels
2.3.x Magento 2.3 related changes Event: mm20in New Topic A major update published as an entirely new document Partner: Ziffity partners-contribution PR created by Magento partner Progress: approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ajithkumar-maragathavel @devops-devdocs @aleron75 @rogyar @dobooth @sivaschenko @magento-engcom-team