Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

meker12
Copy link
Contributor

@meker12 meker12 commented Feb 11, 2020

Purpose of this pull request

Make Docker Launch instructions more accessible:

  • Added the Docker Development > Launch Docker navigation heading
  • Changes the top-level navigation title from "Launch Docker" to
    "Configure and launch Docker"
  • Updated the Launch developer and Launch production topics to include
    links to the Docker configuration topics
  • Changed title of "Launch modes" subsection to add what launch modes
    are for == "Launch modes for configuring the Docker environment"

Affected DevDocs pages

accessible:
- Added the Docker Development > Launch Docker navigation heading
- Changes the top-level navigation title from "Launch Docker" to
"Configure and launch Docker"
- Updated the Launch developer and Launch production topics to include
 links to the Docker configuration topics
- Changed title of "Launch modes" subsection to add what launch modes
are for
Cloud Guide_ to include new requirement to specify `--with-cron` option
to build a Magento Cloud Docker environment that includes a Cron
container.
@meker12 meker12 self-assigned this Feb 11, 2020
@meker12 meker12 added Internal Dev Differentiates work between community and Magento staff 2.x Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies labels Feb 11, 2020
Copy link
Contributor

@hguthrie hguthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some links could be improved and the Launch modes title seems bloated and not very useful.

@meker12 meker12 changed the title Updated Cloud Guide navigation to make launch instructions more Updated Cloud Guide navigation for accessible Docker launch instructions Feb 13, 2020
@meker12 meker12 requested a review from hguthrie February 13, 2020 01:40
@meker12
Copy link
Contributor Author

meker12 commented Feb 14, 2020

running tests

@meker12
Copy link
Contributor Author

meker12 commented Feb 14, 2020

running tests

@meker12 meker12 merged commit 722df7b into master Feb 14, 2020
@ghost
Copy link

ghost commented Feb 14, 2020

Hi @meker12, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@meker12 meker12 deleted the mae-cloud-guide-post-release-fixes branch February 14, 2020 18:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.x Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Internal Dev Differentiates work between community and Magento staff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants