This repository was archived by the owner on Nov 19, 2024. It is now read-only.
magento/devdocs#: Add mergeCarts query API errors #6628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Atwix
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
atwixfirster
force-pushed
the
api-errors-mergeCarts
branch
from
715bb0c to
7e166f8
Compare
rogyar
reviewed
Feb 12, 2020
| `Current user does not have an active cart.` | `mergeCarts` mutation deactivates provided in the `source_cart_id` attribute guest's cart after merge, thus guest will be not able to make any further operations with it. | ||
| `Required parameter "destination_cart_id" is missing` | The `destination_cart_id` attribute contains an empty value. | ||
| `Required parameter "source_cart_id" is missing` | The `source_cart_id` attribute contains an empty value. | ||
| `The current customer isn't authorized.` | The current customer is not currently logged in, or the customer's token does not exist in the `oauth_token` table, or you tried to merge guests carts. |
There was a problem hiding this comment.
you tried to merge guests carts
Thats a very good point 👍
rogyar
added
the
Technical
rogyar
approved these changes
Feb 12, 2020
keharper
suggested changes
Feb 12, 2020
There was a problem hiding this comment.
@atwixfirster The description of the first error wasn't clear to me, so I'm just leaving suggested edits, instead of editing the PR directly.
|
|
||
| Error | Description | ||
| --- | --- | ||
| `Current user does not have an active cart.` | `mergeCarts` mutation deactivates provided in the `source_cart_id` attribute guest's cart after merge, thus guest will be not able to make any further operations with it. |
There was a problem hiding this comment.
Suggested change
| `Current user does not have an active cart.` | `mergeCarts` mutation deactivates provided in the `source_cart_id` attribute guest's cart after merge, thus guest will be not able to make any further operations with it. | |
| `Current user does not have an active cart.` | The `mergeCarts` mutation deactivates the guest cart specified in the `source_cart_id` after merging. The guest cannot make any further operations with it. |
| `Current user does not have an active cart.` | `mergeCarts` mutation deactivates provided in the `source_cart_id` attribute guest's cart after merge, thus guest will be not able to make any further operations with it. | ||
| `Required parameter "destination_cart_id" is missing` | The `destination_cart_id` attribute contains an empty value. | ||
| `Required parameter "source_cart_id" is missing` | The `source_cart_id` attribute contains an empty value. | ||
| `The current customer isn't authorized.` | The current customer is not currently logged in, or the customer's token does not exist in the `oauth_token` table, or you tried to merge guests carts. |
There was a problem hiding this comment.
Suggested change
| `The current customer isn't authorized.` | The current customer is not currently logged in, or the customer's token does not exist in the `oauth_token` table, or you tried to merge guests carts. | |
| `The current customer isn't authorized.` | The current customer is not currently logged in, or the customer's token does not exist in the `oauth_token` table, or you tried to merge two guest carts. |
| `Required parameter "destination_cart_id" is missing` | The `destination_cart_id` attribute contains an empty value. | ||
| `Required parameter "source_cart_id" is missing` | The `source_cart_id` attribute contains an empty value. | ||
| `The current customer isn't authorized.` | The current customer is not currently logged in, or the customer's token does not exist in the `oauth_token` table, or you tried to merge guests carts. | ||
| `The current user cannot perform operations on cart` | Authorized customer tries to merge a guest cart into a cart of another customer. |
There was a problem hiding this comment.
Suggested change
| `The current user cannot perform operations on cart` | Authorized customer tries to merge a guest cart into a cart of another customer. | |
| `The current user cannot perform operations on cart` | The authorized customer tried to merge a guest cart into the cart of another customer. |
atwixfirster
force-pushed
the
api-errors-mergeCarts
branch
from
7e166f8 to
160358c
Compare
|
@keharper all your suggestions have been implemented. Could you please review? Thank you! |
atwixfirster
force-pushed
the
api-errors-mergeCarts
branch
from
160358c to
1995224
Compare
keharper
approved these changes
Feb 14, 2020
|
Hi @atwixfirster, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) adds information about the API errors of
mergeCartsmutation.Affected DevDocs pages
Links to Magento source code