Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Added release item full page cache fix #6723

Merged
merged 3 commits into from
Feb 27, 2020
Merged

Added release item full page cache fix #6723

merged 3 commits into from
Feb 27, 2020

Conversation

meker12
Copy link
Contributor

@meker12 meker12 commented Feb 25, 2020

Purpose of this pull request

Added release note info for full page cache patch fix included in the Cloud Patches v1.0.3 release

Affected DevDocs pages

@meker12
Added release item full page cache fix
4c3dc76 
Added release note info for full page cache patch fix included in the Cloud Patches v1.0.3 release
@meker12 meker12 added 2.x Internal Dev Differentiates work between community and Magento staff Technical Updates to the code or processes that alter the technical content of the doc labels Feb 25, 2020
@meker12 meker12 self-assigned this Feb 25, 2020
@meker12 meker12 requested a review from YPyltiai February 25, 2020 20:04
YPyltiai
YPyltiai approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@YPyltiai YPyltiai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meker12 , since we don't have link to this patch on Magento.com, I wouldn't use its name as a reference - would just put in what it fixes. This would make it lighter I think but I am good with current version too.

@meker12
Copy link
Contributor Author

meker12 commented Feb 25, 2020

@meker12 , since we don't have link to this patch on Magento.com, I wouldn't use its name as a reference - would just put in what it fixes. This would make it lighter I think but I am good with current version too.

Good idea-- the name is awkward. We can have some patch naming conventions to avoid this problem.

@meker12
Reordered 1.0.2 release items per review feedback
b1413f7 
Changes icons to use "new" for new patches, and "fix" for patch fixes and other fixes
@meker12 meker12 requested a review from hguthrie February 26, 2020 18:22
hguthrie
hguthrie reviewed Feb 26, 2020
View reviewed changes
Copy link
Contributor

@hguthrie hguthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few comments about distilling the lead-in phrase, how links interfere, and the general use of the fancy bullets. I don't think the fancy bullets apply to patches very well. I also used a consistent statement about to which product and version the patch applies. I wonder if a table could be useful. I don't know, because sometimes the explanation may need to be longer and that generally becomes difficult to read in a table. Lot to think about. Try these comments, though.

@meker12 meker12 requested a review from hguthrie February 27, 2020 16:10
hguthrie
hguthrie approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@hguthrie hguthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner and easier to read!

@meker12 meker12 merged commit c2a44e1 into Cloud-package-release Feb 27, 2020
@ghost
Copy link

ghost commented Feb 27, 2020

Hi @meker12, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

meker12 added a commit that referenced this pull request Feb 27, 2020
@meker12 @hguthrie
Cloud package release (#6700)
710de24 
* - Added Cloud Components 1.0.2 release notes
- Added ece-tools 2002.0.23 release notes
- Added release date to release note header for recent package releases

* Updated release notes for Patches v1.0.2 (#6675)

* Updated release notes for Patches v1.0.2
* Added additional release notes for Patches 1.0.2 release
* Add release dates to Patches release note version headers

* Update src/cloud/release-notes/ece-release-notes.md

Co-Authored-By: hguthrie <hguthrie@users.noreply.github.com>

* Update src/cloud/release-notes/ece-release-notes.md

* Added release item full page cache fix (#6723)

* Added release item full page cache fix

* Reordered 1.0.2 release items per review feedback
* Removed "fix" and "new" icons as they don't really apply to the Patches updates since all patches are fixes


Co-authored-by: hguthrie <hguthrie@users.noreply.github.com>
@meker12 meker12 deleted the mae-cloud-patches-release-notes-update branch March 23, 2020 17:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@hguthrie hguthrie hguthrie approved these changes

@YPyltiai YPyltiai YPyltiai approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@hguthrie hguthrie

@meker12 meker12

Labels
2.x Internal Dev Differentiates work between community and Magento staff Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meker12 @hguthrie @YPyltiai