magento/devdocs#6535: Clarify behavior of plugins in Plugins (Interceptors) topic #6811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Atwix
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
rogyar
suggested changes
Mar 8, 2020
| The execution will be in this order: | ||
|
|
||
| * `PluginA::beforeDispatch()` | ||
| * `PluginB::beforeDispatch()` | ||
| * `PluginB::aroundDispatch()` (Magento calls the first half until `callable`) | ||
| * `PluginB::aroundDispatch()` (Magento calls the first half after `callable`) |
There was a problem hiding this comment.
I'm not sure this statement is 100% correct. The around plugin is supposed to be executed before callable and after callable. In the modified example it's being executed two times before callable.
* `PluginB::aroundDispatch()` (Magento calls the first half after `callable`)
* `PluginB::aroundDispatch()` (Magento calls the second half after `callable`)
There was a problem hiding this comment.
rogyar
approved these changes
Mar 9, 2020
dobooth
approved these changes
Mar 12, 2020
|
running tests |
|
Hi @atwixfirster, thank you for your contribution! |
sidolov
added
Major Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) provides additional explanations for plugins order execution regarding to #6535.
Affected DevDocs pages
Links to Magento source code
whatsnew
Added execution order examples to Plugin (Interceptors).