This repository was archived by the owner on Nov 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Added example on how to adjust the validation message for specific form field #6937
Merged
dobooth
merged 6 commits into
magento:master
from
vasilii-b:custom-validation-message-based-on-form-input-name
Apr 1, 2020
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3b21949
Added example on how to adjust the validation message for specific fo…
6086890
Fixed wrong referenced module name
bda1efe
adjusted added html code block
4375df8
Editorial pass
dobooth 9ae4e2a
Add header
dobooth 838a026
Merge branch 'master' into custom-validation-message-based-on-form-in…
dobooth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vasilii-b. Thank you for the great example. Could I ask you to add an extended explanation of what exactly needs to be done in order to adjust the message for a specific field?
The example below shows how it's done in the core but it does not explain the process explicitly. The question that may appear, do we need to modify the
errorPlacement
for adjusting the message or it's enough to add the corresponding item into themessages
object?Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rogyar,
Thanks for looking into it.
Answering your question - no, the
errorPlacement
does not affect the modification of the message.The
errorPlacement
adjusts where the validation message will show up when the validation rule not passed.I'll update the file accordingly.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!