Add html example for adding a new class to the <body> tag #6989

abrarpathan19 · 2020-04-05T06:34:31Z

Purpose of this pull request

Added an html example for adding a new class to the tag.

Affected DevDocs pages

https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/layouts/xml-manage.html

whatsnew
Added HTML example in the Common layout customization tasks topic.

devops-devdocs · 2020-04-05T06:35:02Z

An admin must run tests on this PR before it can be merged.

meker12 · 2020-04-05T07:18:49Z

src/guides/v2.3/frontend-dev-guide/layouts/xml-manage.md

+        <attribute name="class" value="my-new-body-class"/>
+    </body>
+```
+


This example is already provided on lines 229-237.

Delete this example. It duplicates the example that appears on 229-237:

Example: Add a new class to the body tag.

<page> <body> <attribute name="class" value="my-new-body-class"/> </body> </page>

Still need to delete this example -- Make sure you check for linting errors -- no trailing spaces or extra blank lines after deleting.

If you check the test results at the bottom of the PR, you'll see that this PR is failing.

meker12 · 2020-04-05T07:43:04Z

src/guides/v2.3/frontend-dev-guide/layouts/xml-manage.md

@@ -246,6 +246,16 @@ To set attributes for the HTML `body` tag use the `<attribute>` instruction.
 </page>
 ```

+Also from admin site __Layout Update XML__ field of __Design__ section on _Content Edit_ page  set attributes for the HTML `body` tag use the `<attribute>` instruction.


I'm not sure what you are trying to do by adding this information here. Can you provide more information about the reason you want to include this update here?

We do have Merchant documentation that explains how to do this from the Admin: https://docs.magento.com/m2/ee/user_guide/design/layout-update-place-block.html

Hello @meker12,
This information is for adding custom class in <body> from admin, No need to add code in XML or PHTML

abrarpathan19 · 2020-04-06T14:59:37Z

Hello @meker12, I have updated PR as per requested.

src/guides/v2.3/frontend-dev-guide/layouts/xml-manage.md

meker12 · 2020-04-06T15:38:17Z

src/guides/v2.3/frontend-dev-guide/layouts/xml-manage.md

+        <attribute name="class" value="my-new-body-class"/>
+    </body>
+```
+


Delete this example. It duplicates the example that appears on 229-237:

Example: Add a new class to the body tag.

<page> <body> <attribute name="class" value="my-new-body-class"/> </body> </page>

meker12 · 2020-04-06T15:47:38Z

src/guides/v2.3/frontend-dev-guide/layouts/xml-manage.md

+    </body>
+```
+
+![Block Class]({{ site.baseurl }}/common/images/body-class-result.png)


Move the image after the original example for adding a new class to the body tag-- after line 237.

Co-Authored-By: Margaret Eker <meker@adobe.com>

meker12

Still need to delete the duplicate example and fix linting error.

abrarpathan19 · 2020-04-06T17:27:32Z

Still need to delete the duplicate example and fix linting error.

@meker12 I have updated file, please review again.

Thanks

meker12 · 2020-04-06T18:23:51Z

running tests

ghost · 2020-04-06T18:54:34Z

Hi @abrarpathan19, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Update xml-manage.md

0a70f97

magento-engcom-team added Partner: Krish TechnoLabs partners-contribution PR created by Magento partner Event: Global-Contribution-Day labels Apr 5, 2020

meker12 suggested changes Apr 5, 2020

View reviewed changes

m2-community-project bot assigned meker12 Apr 5, 2020

m2-community-project bot added Progress: changes requested Progress: review and removed Progress: changes requested labels Apr 5, 2020

meker12 changed the title ~~Add a new class to the <body> tag from admin~~ Add example for adding a custom class customizing specific layouts from the Magento Admin Apr 5, 2020

meker12 changed the title ~~Add example for adding a custom class customizing specific layouts from the Magento Admin~~ Add example for adding a custom class from the Magento Admin Apr 5, 2020

AddedExampleImages

f986378

meker12 suggested changes Apr 6, 2020

View reviewed changes

abrarpathan19 and others added 2 commits April 6, 2020 22:30

Update src/guides/v2.3/frontend-dev-guide/layouts/xml-manage.md

cdbd01f

Co-Authored-By: Margaret Eker <meker@adobe.com>

Update xml-manage.md

586f750

meker12 changed the title ~~Add example for adding a custom class from the Magento Admin~~ Add html example for adding a new class to the <body> tag Apr 6, 2020

m2-community-project bot added Progress: changes requested and removed Progress: review labels Apr 6, 2020

meker12 added the Technical Updates to the code or processes that alter the technical content of the doc label Apr 6, 2020

meker12 suggested changes Apr 6, 2020

View reviewed changes

Update xml-manage.md

93fd7ef

meker12 approved these changes Apr 6, 2020

View reviewed changes

m2-community-project bot added Progress: approved and removed Progress: changes requested labels Apr 6, 2020

Merge branch 'master' into patch-93

1256d1b

meker12 merged commit 35f7a0f into magento:master Apr 6, 2020

m2-community-project bot removed the Progress: approved label Apr 6, 2020

hguthrie added the 2.3.x Magento 2.3 related changes label Apr 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add html example for adding a new class to the <body> tag #6989

Add html example for adding a new class to the <body> tag #6989

Uh oh!

abrarpathan19 commented Apr 5, 2020 •

edited by dshevtsov

Loading

Uh oh!

devops-devdocs commented Apr 5, 2020

Uh oh!

meker12 Apr 5, 2020

Uh oh!

meker12 Apr 6, 2020

Uh oh!

meker12 Apr 6, 2020 •

edited

Loading

Uh oh!

meker12 Apr 5, 2020 •

edited

Loading

Uh oh!

abrarpathan19 Apr 5, 2020

Uh oh!

abrarpathan19 commented Apr 6, 2020

Uh oh!

Uh oh!

meker12 Apr 6, 2020

Uh oh!

meker12 Apr 6, 2020

Uh oh!

meker12 left a comment

Uh oh!

abrarpathan19 commented Apr 6, 2020

Uh oh!

meker12 commented Apr 6, 2020

Uh oh!

ghost commented Apr 6, 2020

Uh oh!

Uh oh!

Add html example for adding a new class to the <body> tag #6989

Add html example for adding a new class to the <body> tag #6989

Uh oh!

Conversation

abrarpathan19 commented Apr 5, 2020 • edited by dshevtsov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this pull request

Affected DevDocs pages

Uh oh!

devops-devdocs commented Apr 5, 2020

Uh oh!

meker12 Apr 5, 2020

Choose a reason for hiding this comment

Uh oh!

meker12 Apr 6, 2020

Choose a reason for hiding this comment

Uh oh!

meker12 Apr 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

meker12 Apr 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abrarpathan19 Apr 5, 2020

Choose a reason for hiding this comment

Uh oh!

abrarpathan19 commented Apr 6, 2020

Uh oh!

Uh oh!

meker12 Apr 6, 2020

Choose a reason for hiding this comment

Uh oh!

meker12 Apr 6, 2020

Choose a reason for hiding this comment

Uh oh!

meker12 left a comment

Choose a reason for hiding this comment

Uh oh!

abrarpathan19 commented Apr 6, 2020

Uh oh!

meker12 commented Apr 6, 2020

Uh oh!

ghost commented Apr 6, 2020

Uh oh!

Uh oh!

abrarpathan19 commented Apr 5, 2020 •

edited by dshevtsov

Loading

meker12 Apr 6, 2020 •

edited

Loading

meker12 Apr 5, 2020 •

edited

Loading