Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

devops-devdocs
Copy link
Collaborator

@devops-devdocs devops-devdocs commented Apr 28, 2020

Generated doc updates for backward incompatible changes between 2.3.4 - 2.3.5 codebases.

whatsnew
Generated documentation updates for backward incompatible changes between 2.3.4 - 2.3.5 codebases.

@devops-devdocs
Copy link
Collaborator Author

An admin must run tests on this PR before it can be merged.

@dshevtsov dshevtsov self-assigned this Apr 28, 2020
@dshevtsov dshevtsov added Major Update Significant original updates to existing content 2.3.5 and removed Progress: review labels Apr 28, 2020
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is correct, but it contains more BICs than what is documented in the internal wiki. Maybe the wiki hasn't been updated to reflect the latest state, but I would expect it to match the contents of this PR (for MINOR BICs only). How else are we supposed to validate these type of PRs?

@dshevtsov
Copy link
Collaborator

How else are we supposed to validate these type of PRs?

I don't know. The tool we use is supposed to return true results.

@dshevtsov
Copy link
Collaborator

running tests

@dshevtsov dshevtsov merged commit 6d7072b into master Apr 28, 2020
@ghost
Copy link

ghost commented Apr 28, 2020

Hi @devops-devdocs, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dobooth dobooth deleted the BICs-2.3 branch May 7, 2020 18:17
@dobooth dobooth restored the BICs-2.3 branch May 7, 2020 18:17
@dobooth dobooth deleted the BICs-2.3 branch August 6, 2020 15:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.3.5 Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants