Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Revisions to upgrade instructions for 2.4.0 #7232

Merged
merged 5 commits into from
May 18, 2020

Conversation

jeff-matthews
Copy link
Contributor

@jeff-matthews jeff-matthews commented May 18, 2020

Purpose of this pull request

This pull request (PR):

  • Removes the "Experimental" label from the Composer upgrade plugin TOC entry. The plugin's GA release is scheduled for 2.4.0 GA.
  • Capitalizes "Composer"
  • Removes the Upgrade using custom script topic.
  • Revises the summary of the script and plugin options.

Affected DevDocs pages

whatsnew
Removed the topic about using the custom script to upgrade Magento. The Composer update plugin replaces the custom script.

@jeff-matthews jeff-matthews requested a review from dshevtsov May 18, 2020 14:56
@jeff-matthews jeff-matthews added 2.4.0 Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Internal Dev Differentiates work between community and Magento staff labels May 18, 2020
@jeff-matthews jeff-matthews self-assigned this May 18, 2020
@dshevtsov dshevtsov added the 2.3.x Magento 2.3 related changes label May 18, 2020
Copy link
Collaborator

@dshevtsov dshevtsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is not directly relevant to TOC update but is more conceptually referred to the comp-mgr/cli/upgrade-with-script.md.

  1. The topic is identical in both 2.3 and 2.4. I wonder what was a reason to remove a symlinks (cc @keharper).
  2. Do we have a confirmation from @pdohogne-magento that Upgrade using script is relevant for 2.4?

@jeff-matthews
Copy link
Contributor Author

@pdohogne-magento, can you confirm?

Do we have a confirmation from @pdohogne-magento that Upgrade using script is relevant for 2.4?

@pdohogne-magento
Copy link

No, that is no longer relevant for 2.4; it has been fully replaced by the plugin.

@jeff-matthews jeff-matthews changed the title Fix the Software Upgrade Guide table of contents Revisions to upgrade instructions for 2.4.0 May 18, 2020
@jeff-matthews jeff-matthews added Major Update Significant original updates to existing content and removed Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies labels May 18, 2020
@jeff-matthews
Copy link
Contributor Author

running tests

@jeff-matthews jeff-matthews merged commit cc97e42 into 2.4.0-develop May 18, 2020
@ghost
Copy link

ghost commented May 18, 2020

Hi @jeff-matthews, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@jeff-matthews jeff-matthews deleted the fix-upgrade-toc branch May 18, 2020 22:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.3.x Magento 2.3 related changes 2.4.0 Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants