This repository was archived by the owner on Nov 19, 2024. It is now read-only.
G arvind magecloud 155 #7269
Merged
G arvind magecloud 155 #7269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meker12
requested review from
06romix and
hguthrie
and removed request for
06romix
meker12
added
Partner: Zilker Technology
Technical
hguthrie
suggested changes
May 22, 2020
src/cloud/docker/docker-extend.md
Outdated
| - On the command line, navigate to FPM image directory. | ||
|
|
||
| ```bash | ||
| cd magento-cloud-docker/images/php/fpm |
There was a problem hiding this comment.
This might error if user is still in the magento-cloud-docker/src/Compose/Php directory.
Co-authored-by: hguthrie <hguthrie@users.noreply.github.com>
hguthrie
approved these changes
May 22, 2020
m2-community-project
bot
added
Progress: approved
and removed
Progress: changes requested
labels
|
running tests |
|
Hi @meker12, thank you for your contribution! |
|
Thank you @G-Arvind :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges updates from #7240
Purpose of this pull request
This pull request covers the process of adding a new PHP extension to PHP images of Cloud Docker.
Affected DevDocs pages
https://devdocs.magento.com/cloud/docker/docker-extend.html
Links to Magento source code
whatsnew
Updated the Extend Docker topic with instructions to update the
magento/magento-cloud-dockerpackage to support a new PHP version.