Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

magento/devdocs#7375: GraphQL: Add support for Inventory In-Store Pickup. #7378

Conversation

swnsma
Copy link
Contributor

@swnsma swnsma commented Jun 9, 2020

Apply changes to devdocs dedicated to In-Store Pickup GraphQl support.

Purpose of this pull request

#7375

Affected DevDocs pages

  • src/guides/v2.4/graphql/queries/cart.md
  • src/guides/v2.4/graphql/mutations/set-shipping-address.md
  • src/_data/toc/graphql.yml
  • src/guides/v2.4/graphql/queries/pickup-locations.md

whatsnew
Added the pickupLocations query, which returns a list of locations that customers can use to pick up their orders.

Apply changes to devdocs dedicated to In-Store Pickup GraphQl support.
@swnsma swnsma requested a review from keharper June 9, 2020 10:59
@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @swnsma. Thank you for the information. Could I ask you to provide a code reference to the actual schema for pickupLocations query, please? It looks like the following PR

https://github.com/magento/inventory/pull/2525/files

mentioned in the original issue does not reflect all actual information about the schema.

Thank you.

Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swnsma thank you! Please, check some adjustments from my end

@rogyar rogyar added New Topic A major update published as an entirely new document 2.4.x Magento 2.4.x related changes labels Jun 9, 2020
@swnsma
Copy link
Contributor Author

swnsma commented Jun 9, 2020

@rogyar, done!
Please re-check!

Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the technical perspective, I see no issues. Thank you.

@keharper
Copy link
Contributor

running tests

@keharper
Copy link
Contributor

running tests

@keharper keharper merged commit 82881b2 into magento:master Jun 11, 2020
@ghost
Copy link

ghost commented Jun 11, 2020

Hi @swnsma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.4.x Magento 2.4.x related changes New Topic A major update published as an entirely new document Partner: Vaimo partners-contribution PR created by Magento partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants