Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Jul 26, 2020

Purpose of this pull request

This pull request (PR) update content for this topic
This content is make misunderstand for use. We should update it to avoid confusing for reader/devs

Recall this issue magento/magento2#24830

Affected DevDocs pages

https://devdocs.magento.com/guides/v2.3/javascript-dev-guide/javascript/custom_js.html

Related docs

https://devdocs.magento.com/guides/v2.3/javascript-dev-guide/javascript/requirejs.html#requirejs-config-deps

Links to Magento source code

  • ...

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@rogyar
Copy link
Contributor

rogyar commented Jul 27, 2020

I'm not sure what is this section about but the deps part of requirejs-config is being merged across all modules/themes. So, technically, we cannot override something in that way. Removing it might be a good idea but maybe there's something behind the scenes that the original author wanted to say. Still not sure.

@mrtuvn mrtuvn force-pushed the update-custom-js branch from 182f873 to cd8b332 Compare July 27, 2020 10:08
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jul 27, 2020

@dshevtsov @rafaelstz Can you guys give me some comments
@rogyar yes i know that but i don't think we can do much with js only when all requirejs-config merged at one. For disable js we need more help with php code. But this seem out of scope of this topic

@mrtuvn mrtuvn force-pushed the update-custom-js branch from cd8b332 to 55ef1a2 Compare July 27, 2020 11:09
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not able to guess the original intention of this description. Well then, considering the fact that this approach is technically is not correct, I assume that it's better to remove this information to avoid further confusion.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Aug 3, 2020

@guz-anton What do you think about this update

@dobooth dobooth added Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies 2.4.0 labels Aug 4, 2020
@dobooth dobooth changed the base branch from master to small-changes August 5, 2020 11:31
@dobooth dobooth changed the base branch from small-changes to master August 5, 2020 11:31
@dobooth dobooth changed the base branch from master to small-changes August 5, 2020 11:33
@dobooth dobooth merged commit 5db40ac into magento:small-changes Aug 5, 2020
@ghost
Copy link

ghost commented Aug 5, 2020

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

2.4.0 Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants