Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

atwixfirster
Copy link
Contributor

Purpose of this pull request

This pull request (PR) adds a new "Skip patches" section to the Apply patches.

Affected DevDocs pages

Links to Magento source code

skip

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.


## Skip Cloud patches

You cannot skip required patches on Cloud projects.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @atwixfirster. This info is definitely useful and might help developers to avoid confusions. But it would be even more helpful if we could extend the info a little bit by explaining what are "required patches" in terms of Magento Commerce Cloud.

What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogyar , I 've added a link to https://github.com/magento/magento-cloud-patches/tree/develop/patches. I think it explains better than any words :)

Thank you for notice!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atwixfirster I don't think this requires a separate section. How about changing to a note and adding after line 16?

{:.bs-callout-info}
When you update {{ site.data.var.ct }} or the {{ site.data.var.mcp-prod }} package, the latest required patches are applied automatically the next time you deploy your project. You cannot skip required patches, or remove them after they have been applied.

Also, we'll be updating this topic for the next release to improve the instructions and clarify the different types of patches (required, hotfixes, and custom).

Copy link
Contributor Author

@atwixfirster atwixfirster Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @meker12 !

Your suggestions have been implemented. However, I have edited your suggestions about You cannot skip required patches, or remove them after they have been applied..

We cannot skip a required patches during a deployment process.

We have the ability to revert changes which patches have made via patches from m2-hotfixes folder. Cloud executes patches from m2-hotfixes folder when a required patches have been applied. In this way we may revert native Cloud patches ;)

Please review a proposed changes.

Thank you!

@meker12 meker12 added the Technical Updates to the code or processes that alter the technical content of the doc label Aug 3, 2020
@meker12 meker12 added the Waiting for Response Waiting for response from internal/external parties label Aug 3, 2020
1. Apply custom patches in the `/m2-hotfixes` directory in alphabetical order by patch name.

{:.bs-callout-info}
When you update `{{site.data.var.ct}}` or the `{{site.data.var.mcp-prod}}` package, the latest required patches are applied automatically the next time you deploy your project. You cannot skip [required patches](https://github.com/magento/magento-cloud-patches/tree/develop/patches) them during a deployment process.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When you update `{{site.data.var.ct}}` or the `{{site.data.var.mcp-prod}}` package, the latest required patches are applied automatically the next time you deploy your project. You cannot skip [required patches](https://github.com/magento/magento-cloud-patches/tree/develop/patches) them during a deployment process.
When you update `{{site.data.var.ct}}` or the `{{site.data.var.mcp-prod}}` package, the latest required patches are applied automatically the next time you deploy your project. You cannot skip [required patches](https://github.com/magento/magento-cloud-patches/tree/develop/patches) during the deployment process.

Copy link
Contributor

@meker12 meker12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small update.

@atwixfirster
Copy link
Contributor Author

One small update.

done

Thank you!

@meker12
Copy link
Contributor

meker12 commented Aug 3, 2020

running tests

@rogyar rogyar removed the Waiting for Response Waiting for response from internal/external parties label Aug 4, 2020
@dobooth dobooth changed the base branch from master to small-changes August 4, 2020 21:40
@dobooth dobooth merged commit d578d59 into magento:small-changes Aug 4, 2020
@ghost
Copy link

ghost commented Aug 4, 2020

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.x Partner: Atwix partners-contribution PR created by Magento partner Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants