-
Notifications
You must be signed in to change notification settings - Fork 1.7k
magento/devdocs#: Cloud. Skip patches. #7643
magento/devdocs#: Cloud. Skip patches. #7643
Conversation
An admin must run tests on this PR before it can be merged. |
ff60c23
to
273c2fe
Compare
src/cloud/project/project-patch.md
Outdated
|
||
## Skip Cloud patches | ||
|
||
You cannot skip required patches on Cloud projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @atwixfirster. This info is definitely useful and might help developers to avoid confusions. But it would be even more helpful if we could extend the info a little bit by explaining what are "required patches" in terms of Magento Commerce Cloud.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rogyar , I 've added a link to https://github.com/magento/magento-cloud-patches/tree/develop/patches. I think it explains better than any words :)
Thank you for notice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atwixfirster I don't think this requires a separate section. How about changing to a note and adding after line 16?
{:.bs-callout-info}
When you update {{ site.data.var.ct }} or the {{ site.data.var.mcp-prod }} package, the latest required patches are applied automatically the next time you deploy your project. You cannot skip required patches, or remove them after they have been applied.
Also, we'll be updating this topic for the next release to improve the instructions and clarify the different types of patches (required, hotfixes, and custom).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @meker12 !
Your suggestions have been implemented. However, I have edited your suggestions about You cannot skip required patches, or remove them after they have been applied.
.
We cannot skip a required patches during a deployment process.
We have the ability to revert changes which patches have made via patches from m2-hotfixes
folder. Cloud executes patches from m2-hotfixes
folder when a required patches have been applied. In this way we may revert native Cloud patches ;)
Please review a proposed changes.
Thank you!
273c2fe
to
b9e8f29
Compare
src/cloud/project/project-patch.md
Outdated
1. Apply custom patches in the `/m2-hotfixes` directory in alphabetical order by patch name. | ||
|
||
{:.bs-callout-info} | ||
When you update `{{site.data.var.ct}}` or the `{{site.data.var.mcp-prod}}` package, the latest required patches are applied automatically the next time you deploy your project. You cannot skip [required patches](https://github.com/magento/magento-cloud-patches/tree/develop/patches) them during a deployment process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you update `{{site.data.var.ct}}` or the `{{site.data.var.mcp-prod}}` package, the latest required patches are applied automatically the next time you deploy your project. You cannot skip [required patches](https://github.com/magento/magento-cloud-patches/tree/develop/patches) them during a deployment process. | |
When you update `{{site.data.var.ct}}` or the `{{site.data.var.mcp-prod}}` package, the latest required patches are applied automatically the next time you deploy your project. You cannot skip [required patches](https://github.com/magento/magento-cloud-patches/tree/develop/patches) during the deployment process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small update.
0665b8a
to
587501b
Compare
done Thank you! |
running tests |
Hi @atwixfirster, thank you for your contribution! |
Purpose of this pull request
This pull request (PR) adds a new "Skip patches" section to the Apply patches.
Affected DevDocs pages
Links to Magento source code