Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

jeff-matthews
Copy link
Contributor

Purpose of this pull request

This pull request (PR) consolidates info about security releases on the policy page.

Affected DevDocs pages

@jeff-matthews jeff-matthews requested review from a team, coreydulimba-ad and smiverma August 3, 2020 15:12
@jeff-matthews jeff-matthews added Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Internal Dev Differentiates work between community and Magento staff Small Changes labels Aug 3, 2020
@coreydulimba-ad
Copy link
Contributor

thanks, Jeff! this looks good to me. not sure if the hot fix part needs to be bolded. I did that in the ticket just to clarify the addition but, i'll leave that up to you to keep / remove

@coreydulimba-ad
Copy link
Contributor

@jeff-matthews oh and one other consideration should we add a link to the policy page? Something like "To read more about our release policy see here" if you think that is not needed then ignore

@jeff-matthews
Copy link
Contributor Author

Thanks @coreydulimba-ad. If we want to draw attention to that sentence, there's probably a better way to do it (e.g., note format). If not, then no bolding is necessary.

@coreydulimba-ad
Copy link
Contributor

@jeff-matthews i don't think we need to draw special attention to it, thanks!

@smiverma
Copy link

smiverma commented Aug 3, 2020

@jeff-matthews and @coreydulimba-ad Do we want to want to change the line to "These releases can also include hotfixes (depending on when these issues are fixed) required to address critical issues that affect the Magento application", to consider the fact that only hotfixes done by code freeze will make it to the patch? Might be confusing but wanted to bring it up.

Copy link
Contributor

@jfrontain jfrontain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use 2.3.5-p2 as an example of a security-only release because we were not able to follow our own patch nomenclature guidelines for 2.3.5. Maybe use 2.3.4 for your example.

@dobooth
Copy link
Contributor

dobooth commented Aug 4, 2020

Is this one ready?

@jeff-matthews
Copy link
Contributor Author

Yes, I think so @dobooth. If @coreydulimba-ad and @smiverma want to add additional language later, they can open a PR.

@dobooth dobooth changed the base branch from master to small-changes August 4, 2020 21:13
@dobooth dobooth merged commit 1e7d006 into small-changes Aug 4, 2020
@ghost
Copy link

ghost commented Aug 4, 2020

Hi @jeff-matthews, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dobooth dobooth deleted the move-security-info branch August 4, 2020 21:13
@dobooth dobooth mentioned this pull request Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Internal Dev Differentiates work between community and Magento staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants