Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for Cloud Docker 1.2.0 release #8198

Merged
merged 5 commits into from
Nov 6, 2020
Merged

Updates for Cloud Docker 1.2.0 release #8198

merged 5 commits into from
Nov 6, 2020

Conversation

meker12
Copy link
Contributor

@meker12 meker12 commented Nov 6, 2020 •
edited
Loading

Purpose of this pull request

  • Updates for Magento Cloud Docker 1.2.0 release notes (MCLOUD-6649)
  • Improves instructions for using the init-docker.sh installation script in the Launch production and launch developer mode
  • Added instructions for building custom docker-compose.yaml file (MCLOUD-7809)

Affected DevDocs pages

whatsnew
Added instructions for building a custom docker-compose.yaml file.

maeker12 added 4 commits November 6, 2020 10:53
Updated Docker Quick reference
d856920 
- Addedd new options to the magento-docker CLI
- Added listing that shows all available options for ece-docker
build:compose command
- Added intro to Docker Compose section
MCLOUD-7809 Added instructions for building custom docker-compose.yam…
a83c161 
…l file
Improved instructions for using the init-docker.sh installation script
2b9a12d
Updates for Magento Cloud Docker 1.2.0 release notes
208f36b
@meker12 meker12 self-assigned this Nov 6, 2020
@meker12 meker12 added Internal Dev Differentiates work between community and Magento staff Progress: ready for review labels Nov 6, 2020
@meker12 meker12 changed the title Updates for Cloud Docker 1.2.0 release notes doc updates Updates for Cloud Docker 1.2.0 release Nov 6, 2020
@meker12 meker12 merged commit a277458 into Cloud-Docker-1.2.0 Nov 6, 2020
@ghost
Copy link

ghost commented Nov 6, 2020

Hi @meker12, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@meker12 meker12 requested review from andriyShevtsov and akartavtsev and removed request for akartavtsev and andriyShevtsov November 6, 2020 21:38
@andriyShevtsov
Copy link
Contributor

I don't see release notes for this task https://github.com/magento-commerce/magento-cloud-docker/pull/5 https://jira.corp.magento.com/browse/MCLOUD-7095

andriyShevtsov
andriyShevtsov reviewed Nov 7, 2020
View reviewed changes
Copy link
Contributor

@andriyShevtsov andriyShevtsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see release notes for this task https://jira.corp.magento.com/browse/MCLOUD-6469 magento/magento-cloud-docker#273

src/cloud/release-notes/mcd-release-notes.md

- **Elasticsearch container**

- {:.new}Added support for Elasticsearch 7.9 for compatibility with upcoming Magento releases.<!--MCLOUD-7190-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also added Elastic 7.7 https://jira.corp.magento.com/browse/MCLOUD-6219

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So for 1.1.2 release, we already had release note for 7.7 support. Do I need to include it again?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Sorry. Looks like PR marked incorrectly with 1.2.0 label

@meker12
Copy link
Contributor Author

meker12 commented Nov 7, 2020

I don't see release notes for this task magento-commerce/magento-cloud-docker#5 https://jira.corp.magento.com/browse/MCLOUD-7095

I talked with @oshmyheliuk about it, and he said that it is internal because image removed was not used for anything. The work was just cleaning up Docker environment by removing unneeded container.

@andriyShevtsov
Copy link
Contributor

I don't see release notes for this task magento-commerce/magento-cloud-docker#5 https://jira.corp.magento.com/browse/MCLOUD-7095

I talked with @oshmyheliuk about it, and he said that it is internal because image removed was not used for anything. The work was just cleaning up Docker environment by removing unneeded container.

Ok. So we should set Require release notes to No. I will do it

@meker12
Copy link
Contributor Author

meker12 commented Nov 7, 2020

Got it. Sorry. Looks like PR marked incorrectly with 1.2.0 label

I think it occurs twice because 7.7 needed to be added to both 1.1 and 1.2 release line.

@meker12
Copy link
Contributor Author

meker12 commented Nov 7, 2020

I don't see release notes for this task magento-commerce/magento-cloud-docker#5 https://jira.corp.magento.com/browse/MCLOUD-7095

I talked with @oshmyheliuk about it, and he said that it is internal because image removed was not used for anything. The work was just cleaning up Docker environment by removing unneeded container.

Ok. So we should set Require release notes to No. I will do it

I put (internal) before release note description. Sometimes internal note is useful to include for research.

@andriyShevtsov
Copy link
Contributor

I don't see release notes for this task https://jira.corp.magento.com/browse/MCLOUD-6469 magento/magento-cloud-docker#273

We have 2 pull requests for this task.Here is one more magento/magento-cloud-docker#277

meker12 added a commit that referenced this pull request Nov 9, 2020
@meker12 @oshmyheliuk
@jeff-matthews @BaDos @hguthrie
Cloud Docker 1.2.0 Release (#8199)
6bcb986 
* MCLOUD-6430: Xdebug not working on Magento Cloud Docker 1.1 (#7810)

* MCLOUD-6430: Xdebug not working on Magento Cloud Docker 1.1

* Update src/cloud/docker/docker-development-debug.md
* MCLOUD-6898: Add option to customize port for MailHog (#7860)
* MCLOUD-6898: Add option to customize port for MailHog
* MCLOUD-6660: Add option to disable MailHog
* Update src/cloud/docker/docker-config.md
* MCLOUD-2789: [Cloud Docker] Add custom ES plugins (#7898)
* MCLOUD-2789: [Cloud Docker] Add support for adding custom ES plugins from services.yaml file to the docker-compose.yml file.
* MCLOUD-6394: Help with running MFTF test generation commands (#7995)
* MCLOUD-6394: Help with running MFTF test generation commands
* Added `--with-test` option to `build:compose` option list
* Update src/cloud/docker/docker-containers.md
  - Added test container
* Update src/cloud/docker/docker-containers-service.md
   Added `--with-test` option to `build:compose` option list
* Update Docker command help (#8197)
* Updated Docker Quick reference
- Addedd new options to the magento-docker CLI
- Added listing that shows all available options for ece-docker
build:compose command
- Added intro to Docker Compose section
* Updates for Cloud Docker 1.2.0 release (#8198)
* MCLOUD-7809 Added instructions for building custom docker-compose.yaml file
* Improved instructions for using the init-docker.sh installation script
* Updates based on review feedback
* Updated Launch developer mode instructions to add step
to apply patches before deploying to a Magento Cloud
Docker environment

Co-authored-by: Oleksandr Shmyheliuk <oshmyheliuk@magento.com>
Co-authored-by: Barny Shergold <barny.shergold@vaimo.com>
Co-authored-by: Jeff Matthews <matthews.jeffery@gmail.com>
Co-authored-by: Bohdan Korablov <korablov@adobe.com>
Co-authored-by: hguthrie <hguthrie@users.noreply.github.com>
meker12 added a commit that referenced this pull request Nov 9, 2020
@bdenham @oshmyheliuk
@andriyShevtsov @meker12 @arhiopterecs @hguthrie @jeff-matthews @BaDos
Cloud packages november release (#8203)
32e9d27 
* ECE-Tools 2002.1.3 docs and release notes (#8161)

* MCLOUD-6939: Errors occur running magento commands in composer cloud docker installation (#8007)

* Added variable to skip composer dump-autoload command processing when deploying a Magento Cloud project to a Cloud Docker environment.

* MCLOUD-7072: Add CLI command for generating .magento.env.yaml (#8040)

* MCLOUD-7072: Add CLI commands for creating and updating .magento.env.yaml
* Apply suggestions from code review
Co-authored-by: Barny Shergold <barny.shergold@vaimo.com>
Co-authored-by: Margaret Eker <meker@adobe.com>

* MCLOUD-6805: ECE-Tools release notes

WIP: updating variables

* MCLOUD-6805: ECE-Tools release notes

First draft

* MCLOUD-6805: ECE-Tools release notes

Fixed double slash on link

* added links to two  hot fixes

* Update services-mysql.md (#8051 
* Update Magento Cloud Docker instructions for adding custom PHP extensions (#8145)

* [Doc] Adding new PHP extensions #155 (#7929)

* Clean up instructions for adding PHP extensions
- Move extension configuration attribute descriptions and examples
to a separate section
* Fixed markdown syntax
* Fix link definitions
* Fix link syntax

* Apply suggestions from code review

Co-authored-by: Yevhen Miroshnychenko <miroshny@adobe.com>
Co-authored-by: Barny Shergold <barny.shergold@vaimo.com>
Co-authored-by: hguthrie <hguthrie@users.noreply.github.com>

* MCLOUD-6805: ECE-Tools release notes

Updated entry for MCLOUD-7098

* MCLOUD-6805: ECE-Tools release notes

Fixed merge conflicts

* Added docs for SKIP_COMPOSER_DUMP_AUTOLOAD

* Apply suggestions from code review

Co-authored-by: Margaret Eker <meker@adobe.com>

* MCLOUD-6805: ECE-Tools release notes

Added release notes entry for #7191

* Update error-codes information with current info (#8152)

* Update error-codes information with current info

- Replaced file with error-code.md file generated from the ece-tools package

* Fixed error messages

* Add source file for generating the error code ref

Co-authored-by: Barny Shergold <barny.shergold@vaimo.com>

* Fixed comment syntax on internal note

* MCLOUD-6805: ECE-Tools release notes

Added release not for MCLOUD-7193

* MCLOUD-6805: ECE-Tools release notes

Fixed silly empty bullet

* MCLOUD-6805: ECE-Tools release notes

Per review, updated additional ece-tools docs changes that are unassociated with the release notes.

* MCLOUD-6805: ECE-Tools release notes

Per review, removed extra space from yaml code block.

* MCLOUD-6805: ECE-Tools release notes

Per review, tweaking the wording for writeable Cloud Docker environments.

* MCLOUD-6805: ECE-Tools release notes

Per review, forgot to clarify the pronoun that.

* MCLOUD-6805: ECE-Tools release notes

Per review, removed extra space, missed it first time around.

* MCLOUD-6805: ECE-Tools release notes

Ordered 'new' release note before fixed

* MCLOUD-6805: ECE-Tools release notes

Added links to documentation.

* MCLOUD-6805: ECE-Tools release notes

Added links to documentation.
* Apply suggestions from code review

* Cloud Docker 1.2.0 Release (#8199)

* MCLOUD-6430: Xdebug not working on Magento Cloud Docker 1.1 (#7810)
* Update src/cloud/docker/docker-development-debug.md
* MCLOUD-6898: Add option to customize port for MailHog (#7860)
* MCLOUD-6898: Add option to customize port for MailHog
* MCLOUD-6660: Add option to disable MailHog
* Update src/cloud/docker/docker-config.md
* MCLOUD-2789: [Cloud Docker] Add custom ES plugins (#7898)
* MCLOUD-2789: [Cloud Docker] Add support for adding custom ES plugins from services.yaml file to the docker-compose.yml file.
* MCLOUD-6394: Help with running MFTF test generation commands (#7995)
* MCLOUD-6394: Help with running MFTF test generation commands
* Added `--with-test` option to `build:compose` option list
* Update src/cloud/docker/docker-containers.md
  - Added test container
* Update src/cloud/docker/docker-containers-service.md
   Added `--with-test` option to `build:compose` option list
* Update Docker command help (#8197)
* Updated Docker Quick reference
- Addedd new options to the magento-docker CLI
- Added listing that shows all available options for ece-docker
build:compose command
- Added intro to Docker Compose section
* Updates for Cloud Docker 1.2.0 release (#8198)
* MCLOUD-7809 Added instructions for building custom docker-compose.yaml file
* Improved instructions for using the init-docker.sh installation script
* Updates based on review feedback
* Updated Launch developer mode instructions to add step
to apply patches before deploying to a Magento Cloud
Docker environment

Co-authored-by: Oleksandr Shmyheliuk <oshmyheliuk@magento.com>
Co-authored-by: Andrii Shevtsov <ashevtsov@magento.com>
Co-authored-by: Margaret Eker <meker@adobe.com>
Co-authored-by: Yevhen Miroshnychenko <miroshny@adobe.com>
Co-authored-by: Barny Shergold <barny.shergold@vaimo.com>
Co-authored-by: hguthrie <hguthrie@users.noreply.github.com>
Co-authored-by: Jeff Matthews <matthews.jeffery@gmail.com>
Co-authored-by: Bohdan Korablov <korablov@adobe.com>
@meker12 meker12 deleted the mae-mcloud-6649-docker-1.2.0-release-notes-doc-updates branch November 9, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andriyShevtsov andriyShevtsov andriyShevtsov left review comments

Assignees

@meker12 meker12

@andriyShevtsov andriyShevtsov

Labels
Internal Dev Differentiates work between community and Magento staff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meker12 @andriyShevtsov