This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Add Datetime Library #8439
Merged
Add Datetime Library #8439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: EY
partners-contribution
keharper
previously requested changes
Dec 23, 2020
There was a problem hiding this comment.
@RakeshJesadiya This PR will require technical review. Adobe/Magento will be shut down from Dec 24 to Jan 4, so it'll be a while until the PR can be processed further.
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: ready for review
labels
keharper
added
2.3.x
keharper
reviewed
Dec 23, 2020
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
|
@keharper I have updated the changes as per your suggestion. Thanks. |
BarnyShergold
approved these changes
Jan 25, 2021
dobooth
approved these changes
Jan 25, 2021
|
running tests |
|
Hi @RakeshJesadiya, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) adds a new page DateTime Library to describe the utilities provided to the date time related method.
Affected DevDocs pages
https://devdocs.magento.com/guides/v2.3/extension-dev-guide/framework/datetime.html
https://devdocs.magento.com/guides/v2.4/extension-dev-guide/framework/datetime.html
Links to Magento source code
https://github.com/magento/magento2/tree/2.4.1/lib/internal/Magento/Framework/Stdlib
whatsnew
Added the DateTime library topic to the PHP Developer Guide.