Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

volodymyrDashuk
Copy link

@volodymyrDashuk volodymyrDashuk commented Jan 25, 2021

Purpose of this pull request

This pull request (PR) adds an example of using the gallery widget.

Affected DevDocs pages

whatsnew
Added an example use case of the gallery widget.

Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce addition


## Code sample

This example shows a use case for a gallery widget on any page.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This example shows a use case for a gallery widget on any page.
This example shows a use case for a gallery widget on any page:

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BarnyShergold
All your suggestions have been implemented!

Thank you!

</script>
```

The breakpoints options are set in the `view.xml` configuration file of a theme. The file is conventionally located in `<theme_dir>/etc`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The breakpoints options are set in the `view.xml` configuration file of a theme. The file is conventionally located in `<theme_dir>/etc`.
The breakpoints options are set in the `view.xml` configuration file of a theme. The file is located in `<theme_dir>/etc`.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BarnyShergold
All your suggestions have been implemented!

Could you please verify this PR?

Thank you!

Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@keharper keharper added 2.3.x Magento 2.3 related changes 2.4.x Magento 2.4.x related changes Major Update Significant original updates to existing content labels Jan 29, 2021
@keharper keharper enabled auto-merge January 29, 2021 02:12
@keharper
Copy link
Contributor

running tests

@keharper keharper merged commit 74c3840 into magento:master Jan 29, 2021
@ghost
Copy link

ghost commented Jan 29, 2021

Hi @DashukVolodymyr, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.3.x Magento 2.3 related changes 2.4.x Magento 2.4.x related changes Major Update Significant original updates to existing content Partner: Atwix partners-contribution PR created by Magento partner Progress: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants