Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

ajithkumar-maragathavel
Copy link
Contributor

@ajithkumar-maragathavel ajithkumar-maragathavel commented Feb 11, 2021

Purpose of this pull request

This pull request (PR) adds information about the Magento admin product option configurations.

Affected DevDocs pages

whatsnew
Added the "Configure product video options from Magento Admin" section to the Configure product video topic.

Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition

@dobooth
Copy link
Contributor

dobooth commented Feb 19, 2021

running tests

@dobooth dobooth enabled auto-merge February 19, 2021 12:43
@dobooth
Copy link
Contributor

dobooth commented Feb 19, 2021

Hi @ajithkumar-maragathavel. Thanks for the contribution. Please add a symlink to the image in the correct spot for the v2.4 version.

@ajithkumar-maragathavel
Copy link
Contributor Author

Hi @ajithkumar-maragathavel. Thanks for the contribution. Please add a symlink to the image in the correct spot for the v2.4 version.

@dobooth Can you please let me know how to do that. I am not sure what change I should make here. Thanks for the review

@dobooth
Copy link
Contributor

dobooth commented Feb 22, 2021

Hi @ajithkumar-maragathavel There is information here: https://github.com/magento/devdocs/wiki/Symlinks You will see many of the v2.4 files are symlinks to v2.3 files, like this one: https://github.com/magento/devdocs/blob/master/src/guides/v2.4/config-guide/cron/custom-cron.md

@ajithkumar-maragathavel
Copy link
Contributor Author

Hi @ajithkumar-maragathavel There is information here: https://github.com/magento/devdocs/wiki/Symlinks You will see many of the v2.4 files are symlinks to v2.3 files, like this one: https://github.com/magento/devdocs/blob/master/src/guides/v2.4/config-guide/cron/custom-cron.md

@dobooth Thanks for the help. I have added the symlink of the image in the respective v2.4 directory. Please review it.

@dobooth dobooth added 2.3.x Magento 2.3 related changes 2.4.x Magento 2.4.x related changes Major Update Significant original updates to existing content labels Mar 1, 2021
@dobooth
Copy link
Contributor

dobooth commented Mar 1, 2021

running tests

@dobooth dobooth merged commit bd5e00b into magento:master Mar 1, 2021
@ghost
Copy link

ghost commented Mar 1, 2021

Hi @ajithkumar-maragathavel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.3.x Magento 2.3 related changes 2.4.x Magento 2.4.x related changes Major Update Significant original updates to existing content Partner: Ziffity partners-contribution PR created by Magento partner Progress: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants