Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: Updated content for the ConfigurableProduct module #8735

Merged
merged 2 commits into from Feb 24, 2021

Conversation

jeff-matthews
Copy link
Contributor

@jeff-matthews jeff-matthews commented Feb 24, 2021

Purpose of this pull request

This pull request (PR) adds content from the recently updated ConfigurableProduct module README.

We typically do not allow manually editing the Module Reference Guide (MRG) data file, however, I'm making an exception in this case for the following reasons:

  • The updated README exists in the 2.4-develop branch of the CE repo (private), so when we run automation to update the MRG for the next 2.4.x release, the content will already be there.
  • There was no where else in devdocs where it was appropriate to document this info.
  • This content resolves two Magento Support tickets and could be helpful to others. Waiting until the next release, which isn't until Q3 2021 (2.4.3), is arbitrarily restrictive.

Affected DevDocs pages

Links to Magento source code

whatsnew
Added information about configuring variables through the theme view.xml file with the ConfigurableProduct module.

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Feb 24, 2021
@jeff-matthews jeff-matthews added 2.4.x Magento 2.4.x related changes Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content labels Feb 24, 2021
@jeff-matthews jeff-matthews self-assigned this Feb 24, 2021
@m2-community-project m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress Feb 24, 2021
@jeff-matthews jeff-matthews requested review from dshevtsov, thiaramus and aleromano89 and removed request for aleromano89 February 24, 2021 17:40
@m2-community-project m2-community-project bot moved this from Review in Progress to Reviewer Approved in Pull Request Progress Feb 24, 2021
@jeff-matthews
Copy link
Contributor Author

running tests

@jeff-matthews jeff-matthews merged commit c9a9201 into master Feb 24, 2021
@jeff-matthews jeff-matthews deleted the MRG-configurableProduct branch February 24, 2021 21:23
@ghost
Copy link

ghost commented Feb 24, 2021

Hi @jeff-matthews, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.4.x Magento 2.4.x related changes Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content Progress: done
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants