New topic - show or hide password checkbox implementation #8837

ajithkumar-maragathavel · 2021-03-25T18:58:33Z

Purpose of this pull request

This pull request (PR) adds a new topic that describes the implementation of the show or the hide password checkbox functionality.

Affected DevDocs pages

New Topic

Links to Magento source code

show or hide password widget created magento2#31482

Fixes #8808

whatsnew
Added the Show or Hide Password Checkbox topic.

BarnyShergold

Great new topic explanation!

src/guides/v2.3/ui_comp_guide/howto/show_or_hide_password_checkbox.md

…-maragathavel/devdocs into show-or-hide-password

ajithkumar-maragathavel · 2021-03-26T12:27:39Z

@BarnyShergold Thanks for the review. I have updated the PR based on your comments. Please have a look at it.

BarnyShergold

Nice!

dobooth · 2021-03-30T17:42:28Z

Nice work, @ajithkumar-maragathavel. Rather than symlink the image, you can put it in src/common/images and call it from there in both versions.

ajithkumar-maragathavel · 2021-03-31T05:20:38Z

Nice work, @ajithkumar-maragathavel. Rather than symlink the image, you can put it in src/common/images and call it from there in both versions.

@dobooth Thanks for the suggestion. I have updated the PR by moving the image to the common directory and removed symlinks as well. Please review it.

dobooth · 2021-04-01T16:55:41Z

@magento import pr to magento-devdocs/devdocs

magento-engcom-team · 2021-04-01T16:56:30Z

@dobooth the pull request successfully imported.

…-maragathavel/devdocs into show-or-hide-password

ajithkumar-maragathavel · 2021-04-06T10:54:59Z

@dobooth I have updated the new topic only for v2.4. Please review it.

dobooth · 2021-04-06T14:58:04Z

@magento import code to magento-devdocs/devdocs

magento-engcom-team · 2021-04-06T14:59:29Z

@dobooth the branch with code successfully imported intomagento-devdocs/devdocs repository. Branch name: imported-magento-devdocs-8837.

ghost · 2021-04-08T14:30:42Z

Hi @ajithkumar-maragathavel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

atwixfirster · 2021-04-09T07:44:30Z

Hi, @ajithkumar-maragathavel !

Thank you for your work here. Sorry for being a bit late on the party but as a reader I would like to know what is a Magento_Customer/js/show-password component and where is I can find it in Magento codebase?

Thank you!

ajithkumar-maragathavel · 2021-04-09T10:53:05Z

Hi, @ajithkumar-maragathavel !

Thank you for your work here. Sorry for being a bit late on the party but as a reader I would like to know what is a Magento_Customer/js/show-password component and where is I can find it in Magento codebase?

Thank you!

@atwixfirster Thanks for the suggestion. I will update the document in a separate PR explaining the Magento_Customer/js/show-password component and I will also add the Magento codebase link.

atwixfirster · 2021-04-09T11:14:14Z

Hi, @ajithkumar-maragathavel !
Thank you for your work here. Sorry for being a bit late on the party but as a reader I would like to know what is a Magento_Customer/js/show-password component and where is I can find it in Magento codebase?
Thank you!

@atwixfirster Thanks for the suggestion. I will update the document in a separate PR explaining the Magento_Customer/js/show-password component and I will also add the Magento codebase link.

Cool. Thank you, @ajithkumar-maragathavel

new topic - show or hide password checkbox implementation

7f11870

magento-engcom-team added Partner: Ziffity partners-contribution PR created by Magento partner labels Mar 25, 2021

m2-community-project bot added the Progress: ready for review label Mar 25, 2021

BarnyShergold suggested changes Mar 26, 2021

View reviewed changes

m2-community-project bot assigned BarnyShergold Mar 26, 2021

m2-community-project bot added Progress: changes requested and removed Progress: ready for review labels Mar 26, 2021

BarnyShergold added New Topic A major update published as an entirely new document and removed Progress: changes requested labels Mar 26, 2021

m2-community-project bot added Progress: on hold Progress: changes requested labels Mar 26, 2021

ajithkumar-maragathavel and others added 4 commits March 26, 2021 17:40

Improvements based on the review comment

81c9cd8

Merge branch 'master' into show-or-hide-password

384f28f

Minor improvments based on the review comment

1667b53

Merge branch 'show-or-hide-password' of https://github.com/ajithkumar…

a629473

…-maragathavel/devdocs into show-or-hide-password

ajithkumar-maragathavel requested a review from BarnyShergold March 26, 2021 12:28

BarnyShergold approved these changes Mar 26, 2021

View reviewed changes

m2-community-project bot added Progress: approved and removed Progress: changes requested Progress: on hold labels Mar 26, 2021

dobooth added 2 commits March 30, 2021 11:57

Merge branch 'master' into show-or-hide-password

ec638c5

Editorial pass

2680ea5

dobooth added 2.3.x Magento 2.3 related changes 2.4.x Magento 2.4.x related changes labels Mar 30, 2021

Removed image symlink, moved image to common directory

d1d621c

dobooth approved these changes Apr 1, 2021

View reviewed changes

m2-community-project bot assigned dobooth Apr 1, 2021

Merge branch 'master' into show-or-hide-password

97f2660

m2-community-project bot added Progress: acceptance testing and removed Progress: approved labels Apr 5, 2021

ajithkumar-maragathavel added 2 commits April 6, 2021 16:22

Updated the new topic only for v2.4

0f3b461

Merge branch 'show-or-hide-password' of https://github.com/ajithkumar…

d70379a

…-maragathavel/devdocs into show-or-hide-password

dobooth added 2 commits April 6, 2021 10:53

removed warning

e3aa93c

edited versions

cd7a5c7

dobooth approved these changes Apr 6, 2021

View reviewed changes

m2-community-project bot added Progress: approved and removed Progress: acceptance testing labels Apr 6, 2021

m2-community-project bot added Progress: acceptance testing and removed Progress: approved labels Apr 8, 2021

magento-cicd2 merged commit 2b814fe into magento:master Apr 8, 2021

m2-community-project bot added Progress: done and removed Progress: acceptance testing labels Apr 8, 2021

New topic - show or hide password checkbox implementation #8837

New topic - show or hide password checkbox implementation #8837

Uh oh!

Conversation

ajithkumar-maragathavel commented Mar 25, 2021 • edited by dobooth Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this pull request

Affected DevDocs pages

Links to Magento source code

Uh oh!

BarnyShergold left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ajithkumar-maragathavel commented Mar 26, 2021

Uh oh!

BarnyShergold left a comment

Choose a reason for hiding this comment

Uh oh!

dobooth commented Mar 30, 2021

Uh oh!

ajithkumar-maragathavel commented Mar 31, 2021

Uh oh!

dobooth commented Apr 1, 2021

Uh oh!

magento-engcom-team commented Apr 1, 2021

Uh oh!

ajithkumar-maragathavel commented Apr 6, 2021

Uh oh!

dobooth commented Apr 6, 2021

Uh oh!

magento-engcom-team commented Apr 6, 2021

Uh oh!

ghost commented Apr 8, 2021

Uh oh!

atwixfirster commented Apr 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ajithkumar-maragathavel commented Apr 9, 2021

Uh oh!

atwixfirster commented Apr 9, 2021

Uh oh!

Uh oh!

ajithkumar-maragathavel commented Mar 25, 2021 •

edited by dobooth

Loading

atwixfirster commented Apr 9, 2021 •

edited

Loading