This repository was archived by the owner on Nov 19, 2024. It is now read-only.
New page for extend catalog rule conditions #8930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Ziffity
partners-contribution
BarnyShergold
suggested changes
May 11, 2021
src/guides/v2.3/extension-dev-guide/extend-catalog-rule-conditions.md
Outdated
Show resolved
Hide resolved
src/guides/v2.3/extension-dev-guide/extend-catalog-rule-conditions.md
Outdated
Show resolved
Hide resolved
src/guides/v2.3/extension-dev-guide/extend-catalog-rule-conditions.md
Outdated
Show resolved
Hide resolved
src/guides/v2.3/extension-dev-guide/extend-catalog-rule-conditions.md
Outdated
Show resolved
Hide resolved
src/guides/v2.3/extension-dev-guide/extend-catalog-rule-conditions.md
Outdated
Show resolved
Hide resolved
src/guides/v2.3/extension-dev-guide/extend-catalog-rule-conditions.md
Outdated
Show resolved
Hide resolved
src/guides/v2.3/extension-dev-guide/extend-catalog-rule-conditions.md
Outdated
Show resolved
Hide resolved
src/guides/v2.3/extension-dev-guide/extend-catalog-rule-conditions.md
Outdated
Show resolved
Hide resolved
src/guides/v2.3/extension-dev-guide/extend-catalog-rule-conditions.md
Outdated
Show resolved
Hide resolved
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: ready for review
labels
BarnyShergold
added
New Topic
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: ready for review
labels
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
|
@BarnyShergold Thanks for the valuable suggestions. I have updated the PR. please review the changes. |
BarnyShergold
approved these changes
May 14, 2021
src/guides/v2.3/extension-dev-guide/extend-catalog-rule-conditions.md
Outdated
Show resolved
Hide resolved
dobooth
reviewed
May 19, 2021
|
|
||
| In the above configuration, the `catalog_rule_form` is a UI component form. It is defined in the `app/code/Magento/CatalogRule/view/adminhtml/ui_component/catalog_rule_form.xml` file. | ||
|
|
||
| The `Magento\CatalogRule\Model\Rule\Condition\Combine` and the `Magento\CatalogRule\Model\Rule\Condition\Product` classes are important for the listed conditions and validations of the specified conditions. |
There was a problem hiding this comment.
@dobooth Both these classes are responsible for the default conditions available in the catalog rule and defines the logic for the validations of those conditions.
That's why I termed it as important
There was a problem hiding this comment.
I rewrote it. Please confirm if it is correct.
There was a problem hiding this comment.
@dobooth Yep, It is correct.
dobooth
approved these changes
Jun 2, 2021
m2-community-project
bot
added
Progress: approved
Progress: acceptance testing
and removed
Progress: review
Progress: approved
labels
|
@magento import pr to magento-devdocs/devdocs |
|
@dobooth the pull request successfully imported. |
|
Hi @ajithkumar-maragathavel, thank you for your contribution! |
m2-community-project
bot
added
Progress: done
and removed
Progress: acceptance testing
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) adds a new page that explains the implementation of the catalog rule conditions and specifies the high-level steps to extend the conditions.
Affected DevDocs pages
Links to Magento source code
Fixes #8224
whatsnew
Added the new Extend Catalog Rule Conditions topic.