Steps to add custom field in payment

[ajithkumar-maragathavel]

Purpose of this pull request

This pull request (PR) adds a new page that explains adding a custom input field on the payment section on the checkout payment step.

Affected DevDocs pages

• New Topic

Links to Magento source code

• https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Checkout/Controller/Onepage/Success.php#L30

Related Pull Requests

• Custom input in payment 1279 #8931

Fixes #8927

whatsnew
Added the topic Add a custom field for an offline payment method to the Customize Checkout tutorial.

[BarnyShergold]

Before I review fully, there were two points that were on the old PR that were not addressed.

POINT 1
Not sure if Steps 1 & 2 need to be this detailed. Just say create Learning/CustomField and register it. Perhaps a link to : https://devdocs.magento.com/videos/fundamentals/create-a-new-module/

POINT 2
This is now a deprecated method. This should be done with a Patch / Declarative Schema : https://devdocs.magento.com/guides/v2.3/extension-dev-guide/declarative-schema/

Whilst not complusory for 2.3 it is now the accepted way and would also apply to the v2.4 of this guide and futureproof the content.

Also database changes should not be done using InstallData, it should be done by a InstallSchema - you have mixed the two.

@dobooth - can we get a second opinion on this? As a 2.4v is needed and 2.3 support it, should this not be done using the declarative schema method?

Please can these be addressed before a detailed check is done?

[ajithkumar-maragathavel]

@BarnyShergold I will fix the Point 1 and update the PR.
Let me wait for the comment from @dobooth and provide the proper fix for the Point 2 later.

[dobooth]

Thanks for the discussion, gents. We should use the declarative schema. We certainly don't want to add new content that we know will be out of date. Let's do it properly. We can help if needed.

[ajithkumar-maragathavel]

@BarnyShergold @dobooth Updated the doc with the declarative schema approach. Please review it.

[keharper]

@ajithkumar-maragathavel This is a great start. It'll probably take 3 or 4 rounds of comments to finalize this PR.

[ajithkumar-maragathavel]

@keharper Thanks for your time for the detailed review. I have updated the requested changes. Let me know if everything fine.

[keharper]

Apologies for taking this long to respond to your previous round of changes.

[keharper]

Forgot to tag @ajithkumar-maragathavel

[keharper]

@ajithkumar-maragathavel There are still quite a few comments from my previous review that have not been addressed. I'll only comment on the new material here.

[dobooth]

@ajithkumar-maragathavel How's this one coming along?

[ajithkumar-maragathavel]

@ajithkumar-maragathavel How's this one coming along?

hey @dobooth yep it's coming good so far. Had couple of rounds of review for this PR.
I have finished all the requested changes. waiting for the further review on the changes.

[keharper]

Thanks for your patience, @ajithkumar-maragathavel. From my perspective, this PR is ready to be merged. @BarnyShergold, any further comments?

[BarnyShergold]

This is an awesome piece of work - looks super clear and easy to follow.

Gold ⭐ !

[dobooth]

Great teamwork here. Thanks for all the effort!

[dobooth]

@magento import pr to magento-devdocs/devdocs

[magento-engcom-team]

@dobooth the pull request successfully imported.

[ghost]

Hi @ajithkumar-maragathavel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.