Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

ishakhsuvarov
Copy link
Contributor

@ishakhsuvarov ishakhsuvarov commented May 24, 2021

Purpose of this pull request

This pull request adds information about Extension Footprint analyzer feature of Magento Marketplace.

Affected DevDocs pages

whatsnew
Added a new topic describing Extension Footprint Analysis on the Magento Marketplace.

@jeff-matthews jeff-matthews added the Internal Dev Differentiates work between community and Magento staff label May 24, 2021
@ghost
Copy link

ghost commented May 24, 2021

Hi @ishakhsuvarov, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ishakhsuvarov ishakhsuvarov reopened this May 24, 2021
Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice new addition

Co-authored-by: Barny Shergold <barny.shergold@vaimo.com>
@jeff-matthews jeff-matthews self-requested a review May 27, 2021 14:00
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new topic @ishakhsuvarov!

I've requested additional changes to get this ready for publication.

Please also add a new entry for this new topic in the table of contents (TOC) file. It probably makes sense to add it near the existing "Code Sniffer" entry: https://github.com/magento/devdocs/blob/master/src/_data/toc/marketplace-sellers.yml#L110

Or maybe it makes more sense to add it further down near the "checks" since this footprint analyzer isn't technically a test. What do you think?

ishakhsuvarov and others added 2 commits May 27, 2021 09:36
Co-authored-by: Jeff Matthews <matthews.jeffery@gmail.com>
@ishakhsuvarov
Copy link
Contributor Author

Thank you for your review and fixes @jeff-matthews

I've added it TOC as the next entry after semantic version check. I think it's a good place for it since it's still a part of technical review even though it's not a test in traditional meaning.

Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @ishakhsuvarov!

@jeff-matthews
Copy link
Contributor

@magento import code to magento-devdocs/devdocs

@magento-engcom-team
Copy link

@jeff-matthews the branch with code successfully imported intomagento-devdocs/devdocs repository. Branch name: imported-magento-devdocs-8962.

@magento-cicd2 magento-cicd2 merged commit 86bb5f6 into magento:master May 27, 2021
@ghost
Copy link

ghost commented May 27, 2021

Hi @ishakhsuvarov, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.x Internal Dev Differentiates work between community and Magento staff New Topic A major update published as an entirely new document Progress: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants