Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

ajithkumar-maragathavel
Copy link
Contributor

@ajithkumar-maragathavel ajithkumar-maragathavel commented Jun 27, 2021

Purpose of this pull request

This pull request (PR) updates the following changes to the Set up multiple websites with the Nginx page.

  • Map directive example is replaced with the $MAGE_RUN_CODE variable.
  • Additional steps added to modify the Base URLs for the newly created stores on the Magento admin.

Affected DevDocs pages

Notes

I have verified the updated Nginx virtual hosts configuration file in my local development environment and I can confirm that the multi-stores are working as expected.

Fixes #6317

whatsnew
Updated and expanded Set up multiple websites or stores with nginx tutorial.

Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few corrections

@ajithkumar-maragathavel
Copy link
Contributor Author

@BarnyShergold Thanks for the review and suggestions. Updated the PR with the requested changes.

@keharper
Copy link
Contributor

keharper commented Jul 2, 2021

@ajithkumar-maragathavel I don't understand why you added a step to configure the URLs to http://german.magento24.com/ and http://french.magento24.com/. The instructions already mention german.mysite.mg and french.mysite.mg many times, but there's no explanation why you'd want to change the addresses to something new in the Admin. Please either correct the addresses or add an explanation of the address mapping.

Also, change all instances of "the Magento admin" to "the Admin"

@keharper keharper self-assigned this Jul 2, 2021
@ajithkumar-maragathavel
Copy link
Contributor Author

@ajithkumar-maragathavel I don't understand why you added a step to configure the URLs to http://german.magento24.com/ and http://french.magento24.com/. The instructions already mention german.mysite.mg and french.mysite.mg many times, but there's no explanation why you'd want to change the addresses to something new in the Admin. Please either correct the addresses or add an explanation of the address mapping.

Also, change all instances of "the Magento admin" to "the Admin"

@keharper I tried to set up the multi-website in my local development environment by following the steps mentioned. But I faced a redirection issue while accessing the german and french websites.

When I try to access the http://french.magento24.com/ website, Magento redirects to the default store instead of the french store. Then I did some debugging and found that the base URL for the french and german stores is not updated properly.

I thought adding one more step to update the base url would be a good improvement on this topic. That's the reason, I have added one more step.

Please let me know your thoughts on this.

@dobooth
Copy link
Contributor

dobooth commented Jul 22, 2021

@keharper

@keharper
Copy link
Contributor

@magento import code to magento-devdocs/devdocs

@magento-engcom-team
Copy link

@keharper the branch with code successfully imported intomagento-devdocs/devdocs repository. Branch name: imported-magento-devdocs-9022.

@keharper keharper added 2.3.x Magento 2.3 related changes 2.4.x Magento 2.4.x related changes Major Update Significant original updates to existing content labels Jul 28, 2021
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit b5751bb into magento:master Jul 28, 2021
@ghost
Copy link

ghost commented Jul 28, 2021

Hi @ajithkumar-maragathavel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.3.x Magento 2.3 related changes 2.4.x Magento 2.4.x related changes Major Update Significant original updates to existing content Partner: Ziffity Progress: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup multiple domains info not correct in Set up multiple websites or stores with nginx topic
6 participants