Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

srsathish92
Copy link
Contributor

@srsathish92 srsathish92 commented Oct 12, 2021

Purpose of this pull request

This pull request (PR) to update the missing node (cache, system) in app/etc/env.php

Affected DevDocs pages

https://devdocs.magento.com/guides/v2.4/config-guide/prod/config-reference-envphp.html

Additional Information

#8854 - Seems this PR merged in V2.3, not in V2.4.

whatsnew
Added the "cache" and "system" descriptions to the env.php reference topic.

Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good update but just needs a bit more clarity

Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I see it fully written, couple of additional suggestions. Then it's all good!

Thanks

@@ -227,6 +259,23 @@ x-frame-options header can be configured using this node.

Learn more about session in [x-frame-options][x-frame-options].

## system

Using this node Magento locks the configuration values in env and then disables the field for editing in Admin.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Using this node Magento locks the configuration values in env and then disables the field for editing in Admin.
Using this node, Magento locks the configuration values in `env.php` and then disables the field for editing in Admin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BarnyShergold Changes done

Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@dobooth
Copy link
Contributor

dobooth commented Oct 22, 2021

@magento import code to magento-devdocs/merchdocs

@dobooth dobooth added 2.4.x Magento 2.4.x related changes Major Update Significant original updates to existing content Progress: approved labels Oct 22, 2021
@m2-github-services
Copy link

@dobooth an error occurred during the Pull Request import.

@dobooth
Copy link
Contributor

dobooth commented Oct 22, 2021

@magento import pr to magento-devdocs/devdocs

@m2-github-services
Copy link

@dobooth the Pull Request is successfully imported.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit ecfce43 into magento:master Oct 22, 2021
@ghost
Copy link

ghost commented Oct 22, 2021

Hi @srsathish92, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.4.x Magento 2.4.x related changes Major Update Significant original updates to existing content Partner: ITG Commerce partners-contribution PR created by Magento partner Progress: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants