Validation list #9356
Validation list #9356
Conversation
|
Wow! Amazing effort here! |
There was a problem hiding this comment.
This is a brilliant piece of work!
Please correct as many changes by accepting the suggestion on the repo itself. Please DO NOT correct locally and then push a new commit - this is because it will be really difficult to check all the updates requested have been done as there are over 60.
You also need to do the following -
- Add this new file to the TOC file - src/_data/toc - around line 189 - currently there is no way to get to your new page
- Add a SYMLINK to the new file in the src/guides/2.4 area
Please also fill in the PR description as requested by the WIKI - this is very important.
Well Done!
|
|
||
| ### validate-state | ||
|
|
||
| It checks for a valid state. |
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: ready for review
labels
dobooth
added
2.3.x
Co-authored-by: Barny Shergold <bshergold@adobe.com>
Symlink added Edits added
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
|
@BarnyShergold done, please review. |
There was a problem hiding this comment.
Awesome turnround speed!
I've made one correction and a suggestion to improve clarity and then it's good to go to
@dobooth - might be worth a second reviewer as there is so much - I may have missed something.
But this is an awesome addition.
| </form> | ||
| ``` | ||
|
|
||
| Field `field-5` holds a credit card type, possible values are: `SO`, `SM`, `VI`, `MC`, `AE`, `DI`, `JCB`, `DN`, `UN`, `MI`, `MD`. |
There was a problem hiding this comment.
As there are so many and some are not obvious - I'd recommend turning this list into a small table and defining what each of the 2 letter codes are.
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
Co-authored-by: Barny Shergold <bshergold@adobe.com>
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
|
@BarnyShergold |
|
@magento import code to magento-devdocs/devdocs |
|
@dobooth the branch with the code is successfully imported into the |
All available form validation rules sorted alphabetically.
Purpose of this pull request
This PR adds a form validation rule list.
Fixes #8951
whatsnew
Added a remarkable Validation rule list to the Frontend Developer's Guide.