Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

cmtickle
Copy link
Contributor

A required rewrite rule has been added to pub/static/.htaccess this causes 404 responses for users of Nginx. This update details the workaround

@ghost ghost self-assigned this Jan 12, 2017
@ghost
Copy link

ghost commented Jan 12, 2017

Thanks, we're confirming this with engineering.

@ghost ghost added the Waiting for Response Waiting for response from internal/external parties label Jan 12, 2017
@cmtickle
Copy link
Contributor Author

This requirement is covered in the sample Nginx configuration of the 2.1 branch introduced in this commit: magento/magento2@b6f19a8
However, relying on this to communicate the change would assume everyone updates their Nginx configuration based on the sample with each new release.

@ghost ghost added the Not DevDocs Issue/PR belongs in different forum; not DevDocs related label Feb 18, 2017
@ghost ghost removed their assignment Apr 5, 2017
@tanberry
Copy link

Hi @cmtickle . Apologies that it has taken so long to reply. After looking at this PR, we would like to suggest that rather than adding the info to the Release Notes for a specific version, we instead add a new topic in devdocs.magento.com, in the Configuration Guide, with the guidance that one should always add version-specific rewrites to the nginx.conf file, and the basic instructions for doing so. And add a link to the nginx.conf.sample file in our repo.

Please let us know your thoughts on that proposal, and, if you are willing to write this topic that would be fantastic. We acknowledge our devdocs contributors by adding their name and a link-back at the top of the topic. We even have templates, to make it very easy. ;-) Please take a look at our Contributor's Guide.

@tanberry tanberry added Site Improvements Updates to tools, processes, and site architecture that improve reader and contributor experience and removed Not DevDocs Issue/PR belongs in different forum; not DevDocs related labels Apr 25, 2017
@tanberry
Copy link

tanberry commented May 2, 2017

@mazhalai Can you please take a quick look and let us know if you agree with this proposal; we want to add a new topic to the Config Guide, advising that one should always add version-specific rewrite configs to the nginx.conf file.

@jcalcaben jcalcaben self-assigned this May 24, 2017
magento-cicd2 pushed a commit that referenced this pull request Jul 12, 2017
@jcalcaben jcalcaben removed the Waiting for Response Waiting for response from internal/external parties label Aug 24, 2017
@jcalcaben jcalcaben merged commit 5157ec3 into magento:develop May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Site Improvements Updates to tools, processes, and site architecture that improve reader and contributor experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants