magento/graphql-ce#41: [Query] My Account > My Orders #212
Conversation
|
|
|
|
||
| $customerId = $this->userContext->getUserId(); | ||
|
|
||
| $this->checkCustomerAccount->execute($customerId, $this->userContext->getUserType()); |
There was a problem hiding this comment.
For consistency purposes it is better to get info about current user from the $context object, it is done this way in all other resolvers.
| # SalesGraphQl | ||
|
|
||
| **SalesGraphQl** provides type and resolver information for the GraphQl module | ||
| to generate sales orders information endpoints. |
There was a problem hiding this comment.
endpoints => queries
endpoints is REST terminology,
queries and mutations is used in GraphQL
| **SalesGraphQl** provides type and resolver information for the GraphQl module | ||
| to generate sales orders information endpoints. | ||
|
|
||
| Also will provides endpoints for modifying an order. |
There was a problem hiding this comment.
endpoints for modifying an order => order mutations
| id: Int | ||
| increment_id: String | ||
| created_at: String | ||
| grant_total: Float |
There was a problem hiding this comment.
grant_total => grand_total
| increment_id: String | ||
| created_at: String | ||
| grant_total: Float | ||
| state: String |
There was a problem hiding this comment.
Why do we need to expose state on the storefront?
There was a problem hiding this comment.
I will tend to provide a lot of info on the order, so the query can be made to extract just you need.
There was a problem hiding this comment.
State is an internal concept, on storefront we normally expose only Status.
| state: String |
There was a problem hiding this comment.
Thanks for info. I changed already
| status: String | ||
| } | ||
|
|
||
| type Orders { |
There was a problem hiding this comment.
Orders => CustomerOrders
| customerOrders: Orders @resolver(class: "Magento\\SalesGraphQl\\Model\\Resolver\\Orders") @doc(description: "List of customer orders") | ||
| } | ||
|
|
||
| type Order @doc(description: "Order mapping fields") { |
| @@ -0,0 +1,56 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Looks like this file was committed by accident. Please remove.
| query { | ||
| customerOrders { | ||
| items { | ||
| id |
There was a problem hiding this comment.
Please correct indentation.
| $orders = $this->collectionFactory->create($customerId); | ||
| $items = []; | ||
|
|
||
| // @TODO Add shipping & billing address in response |
There was a problem hiding this comment.
These should be addressed or moved to new issues before we can merge this PR.
There was a problem hiding this comment.
those todo's can be removed for now, i will come with updates in order to add more info on orders , if that's ok
|
Using the $context in resolver is a bad thing. You should consider to remove the dependency of $context and inject just what you need. Anyway, i changed for now. |
| */ | ||
| private $checkCustomerAccount; | ||
| /** | ||
| * @var CheckCustomerAccount |
There was a problem hiding this comment.
Why concrete implementation is preferable in this case?
IMPORTANT
This interface Magento\CustomerGraphQl\Model\Customer\CheckCustomerAccountInterface;
will be merged in the pull request #213
Description (*)
New module to extract a list of orders by customer
Fixed Issues (if relevant)
#41: [Query] My Account > My Orders
Manual testing scenarios (*)
step 1: Install chrome extension ChromeiQL
step 2: Set endpoint http://<your_host>/graphql?XDEBUG_SESSION_START=idekey
step 3: run grahpql query
{
customerOrders {
items {
id
increment_id
created_at
state
status
grant_total
}
}
}