Skip to content

18541: Set view models as shareable by default #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

18541: Set view models as shareable by default #1954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
152da77
18541: Set view models as shareable by default
nmalevanec Dec 20, 2018
d2d3326
Merge branch '2.3-develop' into 18541
ishakhsuvarov May 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ificationAdminUi/view/adminhtml/layout/inventorylowquantitynotification_lowstock_grid.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<arguments>
<argument name="id" xsi:type="string">gridLowstock</argument>
<argument name="use_ajax" xsi:type="string">0</argument>
<argument name="dataSource" xsi:type="object">Magento\InventoryLowQuantityNotification\Model\ResourceModel\LowQuantityCollection</argument>
<argument name="dataSource" xsi:type="object" shared="false">Magento\InventoryLowQuantityNotification\Model\ResourceModel\LowQuantityCollection</argument>
</arguments>
<block class="Magento\Backend\Block\Widget\Grid\Export" name="adminhtml.block.report.product.inventory.lowstock.export" as="grid.export">
<arguments>
Expand Down
1 change: 1 addition & 0 deletions lib/internal/Magento/Framework/View/Layout/etc/elements.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
<xs:sequence>
<xs:element name="updater" type="updaterType" minOccurs="0" maxOccurs="1"/>
</xs:sequence>
<xs:attribute name="shared" type="xs:boolean" default="true" use="optional"/>
</xs:extension>
</xs:complexContent>
</xs:complexType>
Expand Down