-
Notifications
You must be signed in to change notification settings - Fork 197
MCLOUD-5511: Add Multi-website Support into Cloud Docker #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
images/php/7.1-cli/etc/php-cli.ini
Outdated
@@ -7,3 +7,4 @@ always_populate_raw_post_data = -1 | |||
max_input_vars = 10000 | |||
session.gc_probability = 1 | |||
opcache.enable = 1 | |||
auto_append_file = /app/magento-vars.php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add new line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added. Pls review again
e5efdca
to
5ea30d1
Compare
Created internal task MAGECLOUD-5584 |
To run in Production mode:
version: '2.1'
services:
web:
volumes:
- './magento-vars.php:/app/magento-vars.php:ro' |
@shiftedreality Please take a look. With production mode and |
@andriyShevtsov it looks like the trick with if (!function_exists('isHttpHost')) {
function isHttpHost($host)
{
if (!isset($_SERVER['HTTP_HOST'])) {
return false;
}
return strpos(str_replace('---', '.', $_SERVER['HTTP_HOST']), $host) === 0;
}
} |
I just realized it will break the default behavior. @mohanelamurugan could you please check this PR in Production mode if you have the same problem? |
Sure @shiftedreality , Let me check this |
Thank you. Most likely that issue was not related to your PR. QA approved. |
Description
Added multi website support in cloud docker(Appended magneto-vars.php to php.ini) .
https://jira.corp.magento.com/browse/MCLOUD-5511:
Fixed Issues (if relevant)
MCD-104
Manual testing scenarios
Contribution checklist