[New Rule] Getters SHOULD NOT change the state of an object

[lenaorobei]

Rule

Getters SHOULD NOT change the state of an object.

Reason

Source: Magento Technical Guidelines.

Implementation

Check if method name starts with get and find class member assignment operation inside this method.

<severity>8</severity>
<type>warning</type>

[larsroettig]

Hi @paliarush and @lenaorobei,
I think we get too many false positives it is very hard to Implementing this with tokens maybe with phpstan it is possible to implement this check.