No longer require a space before a colon for control structures using… #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hostep
force-pushed
the
fixes-issue-118
branch
2 times, most recently
from
7426521 to
77d0290
Compare
|
I've added a unit test, but for some reason it's not working properly. If somebody could give me a hint why not, that would be appreciated! It might be because there is no corresponding Sniff added, but does that mean that no unit test is required in this case? |
… the alternative syntax
hostep
force-pushed
the
fixes-issue-118
branch
from
77d0290 to
f7c47a0
Compare
|
I've thought about it some more and it doesn't make much sense to have unit tests for this in the magento-coding-standard repo. The unit tests should be (and are already) part of the PHP_CodeSniffer repo. |
lenaorobei
approved these changes
Aug 21, 2019
|
@hostep thank you for this improvement. |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Dec 17, 2021
AC-391: Static test to cover "deprecated" jQuery methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the alternative syntax
This fixes #118
Documentation: https://github.com/squizlabs/PHP_CodeSniffer/wiki/Customisable-Sniff-Properties#squizcontrolstructurescontrolsignature