Fix ImportsFromTestNamespace from lock on group use with trailing comma #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…laration has trailing coma.
If a grouped use statement has a trailing coma like this:
```
use Magento\Something{
Foo,
Bar,
};
```
`findNext` on line 59 was returning false and next call was starting to search again from line 1 (`$next + 1`) and this function was looping indefinitely through input tokens.
|
@fsw can you please cover this case with a test? |
|
@sivaschenko done. I have modified existing test case. Without the fix it hangs, with the fix it passes. |
sivaschenko
approved these changes
Aug 24, 2021
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
|
@magento import pr to magento-commerce/magento-coding-standard |
|
@sivaschenko the pull request successfully imported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a grouped use statement has a trailing coma like this:
findNexton line 59 was returning false and next call was starting to search again from line 1 ($next + 1) and this function was looping indefinitely through input tokens.