Skip to content

MQE-884: Show warning on generation when leave out .url attribute for… #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

MQE-884: Show warning on generation when leave out .url attribute for… #122

wants to merge 2 commits into from

Conversation

aljcalandra
Copy link
Contributor

… amOnPage

  • Added Warning Line and unit test for said warning/conditional

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

aljcalandra added 2 commits May 7, 2018 09:47
@aljcalandra
MQE-884: Show warning on generation when leave out .url attribute for…
071bd0c 
… amOnPage

- Added Warning Line and unit test for said warning/conditional
@aljcalandra
Merge branch 'develop' into MQE-884
b71431b
@aljcalandra aljcalandra closed this May 7, 2018
@aljcalandra
Copy link
Contributor Author

PR'd wrong branch

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 56.784% when pulling b71431b on MQE-884 into 40b85ab on develop.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 56.784% when pulling b71431b on MQE-884 into 40b85ab on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 56.784% when pulling b71431b on MQE-884 into 40b85ab on develop.

magento-devops-reposync-svc pushed a commit that referenced this pull request Oct 18, 2021
@jilu1
Merge pull request #122 from magento-commerce/imported-karyna-tsymbal…
5a3f391 
…-atwix-magento2-functional-testing-framework-873

[Imported] add check for isBuiltin method (for PHP 8 compatibility)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aljcalandra @coveralls