Skip to content

MQE-1033: Validate duplicate element names in the same file (Section, Data, Metadata, Page) #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 25, 2018
Merged

MQE-1033: Validate duplicate element names in the same file (Section, Data, Metadata, Page) #153

merged 5 commits into from
Jun 25, 2018

Conversation

KevinBKozan
Copy link
Contributor

Description

  • Dom.php classes for all test objects have been created and configured.
  • Above classes now validate uniqueness of certain elements by their keys (ex. <entity><data key="")

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan
MQE-1033: Validate duplicate element names in the same file
41a2505 
- Validation abstracted out to static function.
- Test/Actions covered
- Section/Elements covered
- Entity/Fields covered
- ActionGroup/Actions covered
- Operation recursively covered
@KevinBKozan
MQE-1033: Validate duplicate element names in the same file
c38e9e0 
- Output Fix
@KevinBKozan
MQE-1033: Validate duplicate element names in the same file
fabccf9 
- CR fixes, validationUtil to object instead of static function.
@KevinBKozan
MQE-1033: Validate duplicate element names in the same file
06629dc 
- CR Fixes
@KevinBKozan
Merge branch 'develop' into MQE-1033
4082b1e
@coveralls
Copy link

coveralls commented Jun 23, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.8%) to 56.158% when pulling 4082b1e on MQE-1033 into 6281e31 on develop.

@KevinBKozan KevinBKozan merged commit de1583f into develop Jun 25, 2018
@KevinBKozan KevinBKozan deleted the MQE-1033 branch June 25, 2018 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinBKozan @coveralls