Skip to content

MQE-1073: Mandatory Annotations #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 28, 2018
Merged

MQE-1073: Mandatory Annotations #157

merged 5 commits into from
Jun 28, 2018

Conversation

KevinBKozan
Copy link
Contributor

Description

  • AnnotationExtractor checks for existing annotations and warns users about missing annotations.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

- Added requiredAnnotation check to AnnotationExtractor.
- Downgraded Error to Warning
- Refactored array functions to simple loop
- added unit testing for AnnotationExtractor class
@KevinBKozan KevinBKozan merged commit 7003122 into develop Jun 28, 2018
@KevinBKozan KevinBKozan deleted the MQE-1073 branch June 28, 2018 13:32
magento-devops-reposync-svc pushed a commit that referenced this pull request Feb 14, 2022
MQE-2021 : Added new attribute unique
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant