Skip to content

Conversation

KevinBKozan
Copy link
Contributor

Description

  • <executeJs function=""/> now escapes $variable with \$variable (but not {$variable})

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

- Added conditional in testGenerator to escape javascript variables only in executeJS functions.
@coveralls
Copy link

coveralls commented Jul 5, 2018

Coverage Status

Coverage increased (+0.02%) to 56.039% when pulling 23ed2c0 on MQE-1089 into dd9f789 on develop.

@KevinBKozan KevinBKozan merged commit e829687 into develop Jul 5, 2018
@KevinBKozan KevinBKozan deleted the MQE-1089 branch July 5, 2018 16:00
@soumyau soumyau mentioned this pull request Jan 22, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants