Skip to content

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Aug 29, 2018

Description

Bug fix

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#: Suite Generation - Precondition body must always get and reset driver

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-cicd2
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


**** seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Copy link
Member

@okolesnyk okolesnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jilu1 please update your git configuration by adding username and email to be able to identify your commits

@coveralls
Copy link

coveralls commented Aug 29, 2018

Coverage Status

Coverage decreased (-0.03%) to 57.1% when pulling ed94ab4 on MQE-1189 into 00e78f8 on develop.

@jilu1 jilu1 force-pushed the MQE-1189 branch 2 times, most recently from 1b3ceff to 5c0e5c5 Compare August 29, 2018 16:00
@jilu1
Copy link
Contributor Author

jilu1 commented Aug 29, 2018

I will recreate a PR. close it

@jilu1 jilu1 closed this Aug 29, 2018
@jilu1 jilu1 deleted the MQE-1189 branch August 30, 2018 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants